Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SameSite attribute in MockMvcHttpConnector #30260

Closed
wants to merge 1 commit into from
Closed

Fix SameSite attribute in MockMvcHttpConnector #30260

wants to merge 1 commit into from

Conversation

justin-tay
Copy link
Contributor

Fixes #30249

  • Modified MockCookie to populate attributes using setAttribute.
  • Modified MockMvcHttpConnector to set sameSite using Cookie.getAttribute
  • Added tests

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Mar 31, 2023
@sbrannen sbrannen marked this pull request as draft April 1, 2023 12:48
@sbrannen
Copy link
Member

sbrannen commented Apr 1, 2023

Hi @justin-tay,

Could you please split this PR into two separate PRs to address these two topics?

  1. Update MockCookie to make use of Servlet 6.0 APIs and semantics for "attributes".
  2. Support SameSite attribute in MockMvcHttpConnector.

@sbrannen sbrannen added the status: waiting-for-feedback We need additional information before we can continue label Apr 1, 2023
@sbrannen sbrannen self-assigned this Apr 1, 2023
@sbrannen sbrannen added this to the 6.0.x milestone Apr 1, 2023
@sbrannen sbrannen added in: test Issues in the test module type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Apr 1, 2023
@sbrannen sbrannen mentioned this pull request Apr 1, 2023
Closed
@sbrannen sbrannen added the in: web Issues in web modules (web, webmvc, webflux, websocket) label Apr 1, 2023
@sbrannen sbrannen modified the milestones: 6.0.x, 6.0.8 Apr 1, 2023
@sbrannen
Copy link
Member

sbrannen commented Apr 1, 2023

Superseded by:

@sbrannen sbrannen closed this Apr 1, 2023
@sbrannen sbrannen removed this from the 6.0.8 milestone Apr 1, 2023
@sbrannen sbrannen added status: superseded An issue that has been superseded by another and removed status: waiting-for-feedback We need additional information before we can continue labels Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sbrannen sbrannen

Labels
in: test Issues in the test module in: web Issues in web modules (web, webmvc, webflux, websocket) status: superseded An issue that has been superseded by another type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MockMvcHttpConnector not populating sameSite attribute in cookie
3 participants
@justin-tay @sbrannen @spring-projects-issues