Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log CglibAopProxy errors as WARN instead of INFO #29773

Closed
wants to merge 1 commit into from
Closed

Log CglibAopProxy errors as WARN instead of INFO #29773

wants to merge 1 commit into from

Conversation

qpakzk
Copy link
Contributor

@qpakzk qpakzk commented Jan 5, 2023

Closes gh-29453

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 5, 2023
PennVanan
PennVanan approved these changes Jan 7, 2023
View reviewed changes
Copy link

@PennVanan PennVanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@sbrannen sbrannen added the in: core Issues in core modules (aop, beans, core, context, expression) label Jan 31, 2023
@sbrannen sbrannen mentioned this pull request Jan 31, 2023
Closed
@sbrannen sbrannen changed the title Show the proxy log as warning Log CglibAopProxy errors as WARN instead of INFO Jan 31, 2023
@snicoll snicoll self-assigned this Sep 17, 2023
@snicoll snicoll added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Sep 17, 2023
@snicoll snicoll added this to the 6.1.0-RC1 milestone Sep 17, 2023
snicoll pushed a commit that referenced this pull request Sep 18, 2023
@qpakzk @snicoll
Log attempt at proxying final methods to WARN instead of INFO
fcbe5fa 
See gh-29773
@snicoll snicoll closed this in 6e5c4ef Sep 18, 2023
snicoll added a commit that referenced this pull request Sep 18, 2023
@snicoll
Polish log message
57a4628 
See gh-29773
@snicoll
Copy link
Member

snicoll commented Sep 18, 2023

@qpakzk thank you for making your first contribution to Spring Framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PennVanan PennVanan PennVanan approved these changes

Assignees

@snicoll snicoll

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
6.1.0-RC1
Development

Successfully merging this pull request may close these issues.

CglibAopProxy errors should be logged as warning
5 participants
@qpakzk @snicoll @PennVanan @sbrannen @spring-projects-issues