Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CglibAopProxy errors should be logged as warning #29453

Closed
fvigotti opened this issue Nov 9, 2022 · 2 comments
Closed

CglibAopProxy errors should be logged as warning #29453

fvigotti opened this issue Nov 9, 2022 · 2 comments
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: superseded An issue that has been superseded by another type: enhancement A general enhancement

Comments

@fvigotti
Copy link

fvigotti commented Nov 9, 2022 •
edited by sbrannen
Loading

Good morning ,

I'm not a usual committer, but if someone has 5 minutes...

The following types of errors should be logged as WARNING or ERROR instead of INFO.

INFO 67074 --- [ main] o.s.aop.framework.CglibAopProxy : Unable to proxy interface-implementing method [public final void org.springframework.security.web.authentication.rememberme.AbstractRememberMeServices.loginFail(javax.servlet.http.HttpServletRequest,javax.servlet.http.HttpServletResponse)] because it is marked as final: Consider using interface-based JDK proxies instead!

I've spent 2 days investigating the issue, and it was an @Transactional annotation added to my (Kotlin ) custom implementation of the AbstractRememberMeServices which together with final methods in the abstract class caused this very difficult to spot behavior.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 9, 2022
@sbrannen sbrannen added the in: core Issues in core modules (aop, beans, core, context, expression) label Nov 9, 2022
@sbrannen sbrannen added this to the Triage Queue milestone Nov 9, 2022
qpakzk added a commit to qpakzk/spring-framework that referenced this issue Jan 5, 2023
@qpakzk
Show the proxy log as warning
d049430 
Closes spring-projectsgh-29453
@qpakzk qpakzk mentioned this issue Jan 5, 2023
Closed
@rstoyanchev rstoyanchev removed this from the Triage Queue milestone Jan 20, 2023
@jhoeller jhoeller self-assigned this Jan 24, 2023
@sbrannen
Copy link
Member

PR #29773 will need to be merged or closed as a result of triaging this issue.

@snicoll
Copy link
Member

snicoll commented Sep 17, 2023

Closing in favor of #29773

@snicoll snicoll closed this as not planned Won't fix, can't repro, duplicate, stale Sep 17, 2023
@snicoll snicoll added status: superseded An issue that has been superseded by another and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Sep 17, 2023
@sbrannen sbrannen added the type: enhancement A general enhancement label Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: superseded An issue that has been superseded by another type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Log CglibAopProxy errors as WARN instead of INFO qpakzk/spring-framework
6 participants
@sbrannen @rstoyanchev @snicoll @fvigotti @jhoeller @spring-projects-issues