Wrong observation status tag when a Not Found in a webflux application #31715
Assignees
Labels
in: web
Issues in web modules (web, webmvc, webflux, websocket)
theme: observability
An issue related to observability and tracing
type: backport
An issue that is a backport of another issue to a maintenance branch
type: regression
A bug that is also a regression
Milestone
Comments
github-actions
bot
added
in: web
bclozel
added a commit
that referenced
this issue
Nov 29, 2023
Prior to this commit, regressions were introduced with gh-31417: 1. the observation keyvalues would be inconsistent with the HTTP response 2. the observation scope would not cover all controller handlers, causing traceIds to be missing The first issue is caused by the fact that in case of error signals, the observation was stopped before the response was fully committed, which means further processing could happen and update the response status. This commit delays the stop event until the response is committed in case of errors. The second problem is caused by the change from a `contextWrite` operator to using the `tap` operator with a `SignalListener`. The observation was started in the `doOnSubscription` callback, which is too late in some cases. If the WebFlux controller handler is synchronous non-blocking, the execution of the handler is performed before the subscription happens. This means that for those handlers, the observation was not started, even if the current observation was present in the reactor context. This commit changes the `doOnSubscription` to `doFirst` to ensure that the observation is started at the right time. Fixes gh-31715 Fixes gh-31716
|
Fixed via edadc79 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Backport of gh-31703
The text was updated successfully, but these errors were encountered: