Support pattern matching for method names in ControlFlowPointcut
#31435
Assignees
Labels
in: core
Issues in core modules (aop, beans, core, context, expression)
type: enhancement
A general enhancement
Milestone
Comments
sbrannen
added
in: core
|
Current work on this issue can be viewed in the following feature branch: main...sbrannen:spring-framework:issues/gh-31435-ControlFlowPointcut-pattern-matching |
sbrannen
added a commit
to sbrannen/spring-framework
that referenced
this issue
Oct 27, 2023
Prior to this commit, ControlFlowPointcut supported a single method name which was matched exactly. Although it was possible to extend ControlFlowPointcut to add support for pattern matching, it was a bit cumbersome. To address that, this commit introduces built-in pattern matching support for method names in ControlFlowPointcut, analogous to the pattern matching support in NameMatchMethodPointcut. Specifically, a user can provide one or more method name patterns, and the patterns will be matched against candidate method names using OR semantics. By default, the matching algorithm delegates to PatternMatchUtils.simpleMatch(), but this can be overridden in subclasses by overriding the new protected isMatch() method. Closes spring-projectsgh-31435
sbrannen
added a commit
that referenced
this issue
Oct 28, 2023
Commit d3fba6d introduced built-in pattern matching support for method names in ControlFlowPointcut; however, it was still cumbersome to extend ControlFlowPointcut with support for regular expressions instead of simple pattern matching. To address that, this commit introduces a variant of isMatch() that accepts the pattern index instead of the pre-resolved method name pattern. The default implementation retrieves the method name pattern from the methodNamePatterns field and delegates to isMatch(String, String). Subclasses can override the new isMatch(String, int) method to support regular expressions, as can be seen in the example RegExControlFlowPointcut class in ControlFlowPointcutTests. See gh-31435
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Overview
To address the lack of support for pattern matching for methods names in
ControlFlowPointcutas discussed in #27187, we have decided to introduce such support inControlFlowPointcutanalogous to the support already available inNameMatchMethodPointcut.Specifically, we intend to introduce a
protectedmethod along the lines ofNameMatchMethodPointcut#isMatch(String, String)which by default delegates toPatternMatchUtils.simpleMatch(String, String).That will likely cover the most common use cases for pattern matching; however, users will still be able to extend
ControlFlowPointcutand overrideisMatch(...)in order to support different styles of pattern matching such as regular expressions.Related Issues
ControlFlowPointcutextensibility #27187The text was updated successfully, but these errors were encountered: