Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use StringBuilder.append(char) where possible #27098

Closed
sbrannen opened this issue Jun 25, 2021 · 0 comments
Closed

Use StringBuilder.append(char) where possible #27098

sbrannen opened this issue Jun 25, 2021 · 0 comments
Assignees
@sbrannen
Labels
type: enhancement A general enhancement
Milestone
5.3.9

Comments

@sbrannen
Copy link
Member

To slightly improve performance, we should use StringBuilder.append(char) instead of StringBuilder.append(String) whenever we append a single character to the builder.

See also: #25056
@sbrannen sbrannen added the type: enhancement A general enhancement label Jun 25, 2021
@sbrannen sbrannen added this to the 5.3.9 milestone Jun 25, 2021
@sbrannen sbrannen self-assigned this Jun 25, 2021
izeye added a commit to izeye/micrometer that referenced this issue Jun 30, 2021
@izeye
Use StringBuilder.append(char) where possible
574e34c 
See spring-projects/spring-framework#27098
@izeye izeye mentioned this issue Jun 30, 2021
Merged
shakuzen pushed a commit to micrometer-metrics/micrometer that referenced this issue Jun 30, 2021
@izeye
Use StringBuilder.append(char) where possible (#2674)
0fdedb4 
See spring-projects/spring-framework#27098
@sync-by-unito sync-by-unito bot mentioned this issue Jul 14, 2021
Merged
@jhoeller jhoeller mentioned this issue Jan 12, 2022
Closed
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this issue Mar 26, 2022
@sbrannen @lxbzmy
Use StringBuilder.append(char) where possible
06f5393 
To slightly improve performance, this commit switches to
StringBuilder.append(char) instead of StringBuilder.append(String)
whenever we append a single character to a StringBuilder.

Closes spring-projectsgh-27098
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
5.3.9
Development

No branches or pull requests
1 participant
@sbrannen