Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuring server.jetty.max-connections has no effect #39052

Closed
wants to merge 2 commits into from
Closed

Configuring server.jetty.max-connections has no effect #39052

wants to merge 2 commits into from

Conversation

okohub
Copy link
Contributor

@okohub okohub commented Jan 7, 2024

Fixes #39050

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 7, 2024
@wilkinsona wilkinsona changed the title Fix Jetty ConnectionLimit configuration Configuring server.jetty.max-connections has no effect Jan 8, 2024
@wilkinsona wilkinsona added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 8, 2024
@wilkinsona wilkinsona added this to the 3.2.x milestone Jan 8, 2024
@wilkinsona wilkinsona mentioned this pull request Jan 8, 2024
Closed
@wilkinsona
Copy link
Member

When we merge this, we should look at either using AssertJ's extracting rather than ReflectionUtils or we should test it by trying to make more than the permitted number of connections.

@wilkinsona wilkinsona added the for: merge-with-amendments Needs some changes when we merge label Jan 8, 2024
@mhalbritter mhalbritter removed the for: merge-with-amendments Needs some changes when we merge label Jan 10, 2024
@mhalbritter mhalbritter self-assigned this Jan 10, 2024
@mhalbritter mhalbritter mentioned this pull request Jan 10, 2024
Closed
mhalbritter pushed a commit that referenced this pull request Jan 10, 2024
@okohub @mhalbritter
Fix Jetty ConnectionLimit configuration
7113c10 
See gh-39052
mhalbritter added a commit that referenced this pull request Jan 10, 2024
@mhalbritter
Polish "Fix Jetty ConnectionLimit configuration"
66dc72d 
See gh-39052
@mhalbritter
Copy link
Contributor

Thank you!

@mhalbritter mhalbritter modified the milestones: 3.2.x, 3.2.2 Jan 10, 2024
@okohub okohub deleted the f-fix-jetty-max-connection branch January 16, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mhalbritter mhalbritter

Labels
type: bug A general bug
Projects
None yet
Milestone
3.2.2
Development

Successfully merging this pull request may close these issues.

Jetty ConnectionLimit feature is not working
4 participants
@okohub @wilkinsona @mhalbritter @spring-projects-issues