Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetty ConnectionLimit feature is not working #39050

Closed
okohub opened this issue Jan 7, 2024 · 1 comment
Closed

Jetty ConnectionLimit feature is not working #39050

okohub opened this issue Jan 7, 2024 · 1 comment
Labels
status: superseded An issue that has been superseded by another

Comments

@okohub
Copy link
Contributor

okohub commented Jan 7, 2024

Affects: 3.2.1

Jetty ConnectionLimit feature is introduced via

server.jetty.max-connections in #35899

However, this ConnectionLimit is not working properly due to problem that introduced in this issue #30565

If Spring Boot decided to give first-class support for this, I think we need to find a proper solution.

As a shortcut from #30565, instead of supported prop, this works like a charm.

@Bean
public JettyServerCustomizer connectorsConnectionLimit() {
    return server -> server.addBean(new ConnectionLimit(1, server.getConnectors()));
}

Thanks

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 7, 2024
@wilkinsona wilkinsona added status: superseded An issue that has been superseded by another and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 8, 2024
@wilkinsona
Copy link
Member

Thanks, @okohub. Closing in favor of #39052.

@wilkinsona wilkinsona closed this as not planned Won't fix, can't repro, duplicate, stale Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants