Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add possibility to configure a custom ExecutionContextSerializer in BatchAutoConfiguration #38328

Closed
wants to merge 3 commits into from
Closed

Add possibility to configure a custom ExecutionContextSerializer in BatchAutoConfiguration #38328

wants to merge 3 commits into from

Conversation

cachescrubber
Copy link
Contributor

Add possibility to configure a custom ExecutionContextSerializer in BatchAutoConfiguration

See #38234

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 11, 2023
@cachescrubber
Copy link
Contributor Author

I would like to auto configure a Jackson2ExecutionContextStringSerializer if enables by a use property.

	@Bean
	@ConditionalOnMissingBean(ExecutionContextSerializer.class)
	@ConditionalOnProperty(prefix = "spring.batch.jdbc", name = "use-jackson2-context-serializer", havingValue = "false")
	public Jackson2ExecutionContextStringSerializer executionContextStringSerializer() {
		return new Jackson2ExecutionContextStringSerializer();
	}

@fmbenhassine WDYT?

@mhalbritter mhalbritter added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 13, 2023
@mhalbritter mhalbritter added this to the 3.3.x milestone Nov 13, 2023
@cachescrubber
Merge branch 'main' into batch_custom_context_serializer
a5ac8e2 
# Conflicts:
#	spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/batch/BatchAutoConfiguration.java
#	spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/batch/BatchAutoConfigurationTests.java
@fmbenhassine
Copy link
Contributor

There is no need for a property, the presence of a bean of type ExecutionContextSerializer is enough to be picked up by Boot, otherwise a DefaultExecutionContextSerializer should be used. The last PR update LGTM.

@cachescrubber cachescrubber mentioned this pull request Dec 5, 2023
Closed
@mhalbritter mhalbritter self-assigned this Jan 10, 2024
mhalbritter added a commit that referenced this pull request Jan 10, 2024
@mhalbritter
Add possibility to configure a custom ExecutionContextSerializer in B…
e5b2ad9 
…atchAutoConfiguration

See gh-38328
@mhalbritter
Copy link
Contributor

Thank you very much!

@wilkinsona wilkinsona modified the milestones: 3.3.x, 3.3.0-M1 Jan 10, 2024
izeye added a commit to izeye/spring-boot that referenced this pull request Mar 12, 2024
@izeye
Delegate getExecutionContextSerializer() to DefaultBatchConfiguration…
8bf5b81 
… if not provided

See spring-projectsgh-38328
@izeye izeye mentioned this pull request Mar 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mhalbritter mhalbritter

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.3.0-M1
Development

Successfully merging this pull request may close these issues.
5 participants
@cachescrubber @fmbenhassine @mhalbritter @wilkinsona @spring-projects-issues