Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve and Update BatchAutoConfiguration #38234

Closed
wants to merge 2 commits into from
Closed

Improve and Update BatchAutoConfiguration #38234

wants to merge 2 commits into from

Conversation

cachescrubber
Copy link
Contributor

Improve and Update BatchAutoConfiguration

This PR will update and improve BatchAutoConfiguration

  • Add possibility to configure a custom ExecutionContextSerializer
  • Remove the unnecessary JobOperator bean definition
  • Update JobLauncherApplicationRunner to use JobParameters#getIdentifyingParameters
  • Add a Restarting a stopped or failed Job section to the batch howto.

@wilkinsona
Copy link
Member

Thanks for the proposal, @cachescrubber. While all affecting Spring Batch, the changes all look to be quite separate and probably belong in separate branches:

  • Add possibility to configure a custom ExecutionContextSerializer
    • This is a new feature that we could add in Spring Boot 3.3
  • Remove the unnecessary JobOperator bean definition
    • This looks like it belongs in 3.0.x and later as DefaultBatchConfiguration will have always defined a JobOperator
  • Update JobLauncherApplicationRunner to use JobParameters#getIdentifyingParameters
    • This is an internal change that we could make in 3.2
  • Add a Restarting a stopped or failed Job section to the batch howto.
    • This doc improvement could be made in 3.0.x and later

Do you have time to split the changes out onto four separate branches and four separate PRs? Alternatively, we could cherry-pick the individual pieces to the appropriate places and leave this PR for adding the custom ExecutionContextSerializer support.

@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label Nov 10, 2023
@cachescrubber
Copy link
Contributor Author

Hi @wilkinsona ,

I 'll split the changes out onto four separate branches and PRs. I'll close this and get a fresh fork of spring-boot.

@wilkinsona
Copy link
Member

Thanks very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants