Remove unnecessary test for GraphQL Connection #35449
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes an unnecessary test that checks for the pagination and Connection support in Spring for GraphQL. After a change in spring-projects/spring-graphql#707, we no longer can test this in isolation, nor it make sense to test this integration that deeply.
wilkinsona
approved these changes
May 16, 2023
wilkinsona
pushed a commit
that referenced
this pull request
May 16, 2023
This commit removes an unnecessary test that checks for the pagination and Connection support in Spring for GraphQL. After a change in spring-projects/spring-graphql#707, we no longer can test this in isolation, nor does it make sense to test this integration that deeply. See gh-35449
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes an unnecessary test that checks for the pagination
and Connection support in Spring for GraphQL.
After a change in spring-projects/spring-graphql#707, we no longer can
test this in isolation, nor it make sense to test this integration that
deeply.