Skip to content

Commit

Permalink
Remove unnecessary test for GraphQL Connection
Browse files Browse the repository at this point in the history
This commit removes an unnecessary test that checks for the pagination
and Connection support in Spring for GraphQL. After a change in
spring-projects/spring-graphql#707, we no longer can test this in
isolation, nor does it make sense to test this integration that
deeply.

See gh-35449
  • Loading branch information
bclozel authored and wilkinsona committed May 16, 2023
1 parent 705b2cd commit b261157
Showing 1 changed file with 0 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,9 @@
import graphql.GraphQL;
import graphql.execution.instrumentation.ChainedInstrumentation;
import graphql.execution.instrumentation.Instrumentation;
import graphql.schema.FieldCoordinates;
import graphql.schema.GraphQLFieldDefinition;
import graphql.schema.GraphQLObjectType;
import graphql.schema.GraphQLOutputType;
import graphql.schema.GraphQLSchema;
import graphql.schema.PropertyDataFetcher;
import graphql.schema.idl.RuntimeWiring;
import graphql.schema.visibility.DefaultGraphqlFieldVisibility;
import graphql.schema.visibility.NoIntrospectionGraphqlFieldVisibility;
Expand Down Expand Up @@ -212,17 +209,6 @@ void shouldContributeConnectionTypeDefinitionConfigurer() {
});
}

@Test
void shouldContributeConnectionDataFetcher() {
this.contextRunner.withUserConfiguration(CustomGraphQlBuilderConfiguration.class).run((context) -> {
GraphQlSource graphQlSource = context.getBean(GraphQlSource.class);
GraphQLFieldDefinition books = graphQlSource.schema().getQueryType().getField("books");
FieldCoordinates booksCoordinates = FieldCoordinates.coordinates("Query", "books");
assertThat(graphQlSource.schema().getCodeRegistry().getDataFetcher(booksCoordinates, books))
.isNotInstanceOf(PropertyDataFetcher.class);
});
}

@Configuration(proxyBeanMethods = false)
static class CustomGraphQlBuilderConfiguration {

Expand Down

0 comments on commit b261157

Please sign in to comment.