Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jOOQ DefaultConfiguration does not use TransactionProvider #33979

Closed
wants to merge 2 commits into from

Conversation

ath0s
Copy link
Contributor

@ath0s ath0s commented Jan 25, 2023

Problem

A jOOQ TransactionProvider bean is created, but is not configured to be used by the DefaultConfiguration. This applies to Spring Boot 3.0.0, 3.0.1, 3.0.2.
A recent commit (51df781) removed the DefaultConfigurationCustomizer that configured DefaultConfiguration to use the TransactionProvider if such a bean was available.

Solution

This PR sets the TransactionProvider (if available) when creating the DefaultConfiguration.

@pivotal-cla
Copy link

@ath0s Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 25, 2023
@ath0s

This comment was marked as outdated.

@pivotal-cla
Copy link

@ath0s This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary.

@wilkinsona
Copy link
Member

@ath0s Unfortunately, this doesn't qualify as an obvious fix as it changes functionality. Please sign the CLA.

@pivotal-cla
Copy link

@ath0s Thank you for signing the Contributor License Agreement!

@mhalbritter mhalbritter changed the title Configure jOOQ with TransactionProvider, if available. jOOQ DefaultConfiguration does not use TransactionProvider Jan 31, 2023
@mhalbritter mhalbritter added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 31, 2023
@mhalbritter mhalbritter added this to the 3.0.x milestone Jan 31, 2023
@wilkinsona
Copy link
Member

This was intentional (see https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.5-Release-Notes#customizing-jooqs-defaultconfiguration and #24732) but I think we went too far. Given that Boot itself defines the TransactionProvider bean, it also makes sense for Boot to configure jOOQ to use it without the user having to define a customizer.

@wilkinsona
Copy link
Member

Thanks very much for the PR, @ath0s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants