Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customizer for jOOQ's DefaultConfiguration #24732

Closed
snicoll opened this issue Jan 11, 2021 · 1 comment
Closed

Add customizer for jOOQ's DefaultConfiguration #24732

snicoll opened this issue Jan 11, 2021 · 1 comment
Assignees
Labels
status: noteworthy A noteworthy issue to call out in the release notes type: enhancement A general enhancement
Milestone

Comments

@snicoll
Copy link
Member

snicoll commented Jan 11, 2021

jOOQ has a number of "provider" interface one can implement to tune its behaviour. We've started to look for beans of such type to automatically customise the DefaultConfiguration jOOQ is using.

Over the years, an increasing number of callback interfaces have been added which makes our auto-configuration a bit verbose. Also, it is unclear if those implementations have to be bean in the first place. It feels like they are registered as beans for the sole purpose of being found by the auto-configuration.

Given the current arrangement, we've decided to provide a customizer and let users tune the configuration going forward.

@snicoll snicoll added the type: enhancement A general enhancement label Jan 11, 2021
@snicoll snicoll added this to the 2.5.x milestone Jan 11, 2021
@snicoll snicoll self-assigned this Jan 11, 2021
@snicoll snicoll added the status: noteworthy A noteworthy issue to call out in the release notes label Jan 11, 2021
@snicoll
Copy link
Member Author

snicoll commented Jan 11, 2021

This is noteworthy as checking for the presence of the following beans is now deprecated:

  • ConnectionProvider
  • ExecutorProvider
  • TransactionProvider
  • RecordMapperProvider
  • RecordUnmapperProvider
  • Settings
  • RecordListenerProvider
  • ExecuteListenerProvider
  • VisitListenerProvider
  • TransactionListenerProvider

Users relying on this behaviour can restore the configuration by registering a DefaultConfigurationCustomizer bean that customize the DefaultConfiguration. Note that the underlying provider(s) no longer need to be registered as a bean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: noteworthy A noteworthy issue to call out in the release notes type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant