Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a configuration property for configuring a relying party registration's name ID format #39343

Closed
gbaso opened this issue Jan 30, 2024 · 2 comments
Closed

Provide a configuration property for configuring a relying party registration's name ID format #39343

gbaso opened this issue Jan 30, 2024 · 2 comments
Labels
status: superseded An issue that has been superseded by another

Comments

@gbaso
Copy link

gbaso commented Jan 30, 2024

Support for NameIdFormat was introduced in spring-projects/spring-security#9115, but there is not a corresponding property in Saml2RelyingPartyProperties, and Saml2RelyingPartyRegistrationConfiguration does not set any value on the RelyingPartyRegistration.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 30, 2024
@wilkinsona wilkinsona changed the title SAML2 autoconfiguration does not set NameIdFormat Provide a configuration property for configuring a relying party registration's name ID format Jan 30, 2024
@wilkinsona wilkinsona added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 30, 2024
@wilkinsona wilkinsona added this to the 3.x milestone Jan 30, 2024
@BenchmarkingBuffalo
Copy link
Contributor

Hi @wilkinsona
I would like to work on this issue.
If you want, you can assign it to me.

BenchmarkingBuffalo added a commit to BenchmarkingBuffalo/spring-boot that referenced this issue Feb 4, 2024
@BenchmarkingBuffalo
Add nameIdFormat to Properties
e70d127 
Add the new property nameIdFormat to the Saml2RelyingPartyProperties and the corresponding mapping to the Saml2RelyingPartyRegistrationConfiguration.

See spring-projectsgh-39343
@BenchmarkingBuffalo BenchmarkingBuffalo mentioned this issue Feb 4, 2024
Closed
@scottfrederick
Copy link
Contributor

Closing in favor of #39395

@scottfrederick scottfrederick closed this as not planned Won't fix, can't repro, duplicate, stale Feb 5, 2024
@scottfrederick scottfrederick added status: superseded An issue that has been superseded by another and removed type: enhancement A general enhancement labels Feb 5, 2024
@scottfrederick scottfrederick removed this from the 3.x milestone Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@scottfrederick @wilkinsona @gbaso @spring-projects-issues @BenchmarkingBuffalo