Skip to content

Commit

Permalink
Add nameIdFormat to Properties
Browse files Browse the repository at this point in the history
Add the new property nameIdFormat to the Saml2RelyingPartyProperties and the corresponding mapping to the Saml2RelyingPartyRegistrationConfiguration.

See spring-projectsgh-39343
  • Loading branch information
BenchmarkingBuffalo committed Feb 4, 2024
1 parent 5f87949 commit e70d127
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
* @author Madhura Bhave
* @author Phillip Webb
* @author Moritz Halbritter
* @author Lasse Wulff
* @since 2.2.0
*/
@ConfigurationProperties("spring.security.saml2.relyingparty")
Expand Down Expand Up @@ -72,6 +73,8 @@ public static class Registration {
*/
private final AssertingParty assertingparty = new AssertingParty();

private String nameIdFormat;

public String getEntityId() {
return this.entityId;
}
Expand All @@ -92,12 +95,20 @@ public Decryption getDecryption() {
return this.decryption;
}

public Singlelogout getSinglelogout() {
return this.singlelogout;
}

public AssertingParty getAssertingparty() {
return this.assertingparty;
}

public Singlelogout getSinglelogout() {
return this.singlelogout;
public String getNameIdFormat() {
return this.nameIdFormat;
}

public void setNameIdFormat(String nameIdFormat) {
this.nameIdFormat = nameIdFormat;
}

public static class Acs {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
* @author Phillip Webb
* @author Moritz Halbritter
* @author Lasse Lindqvist
* @author Lasse Wulff
*/
@Configuration(proxyBeanMethods = false)
@Conditional(RegistrationConfiguredCondition.class)
Expand Down Expand Up @@ -104,6 +105,7 @@ private RelyingPartyRegistration asRegistration(String id, Registration properti
builder.singleLogoutServiceResponseLocation(properties.getSinglelogout().getResponseUrl());
builder.singleLogoutServiceBinding(properties.getSinglelogout().getBinding());
builder.entityId(properties.getEntityId());
builder.nameIdFormat(properties.getNameIdFormat());
RelyingPartyRegistration registration = builder.build();
boolean signRequest = registration.getAssertingPartyDetails().getWantAuthnRequestsSigned();
validateSigningCredentials(properties, signRequest);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
* Tests for {@link Saml2RelyingPartyProperties}.
*
* @author Madhura Bhave
* @author Lasse Wulff
*/
class Saml2RelyingPartyPropertiesTests {

Expand Down Expand Up @@ -102,6 +103,13 @@ void customizeSsoSignRequestsIsNullByDefault() {
.getSignRequest()).isNull();
}

@Test
void customizeNameIdFormat() {
bind("spring.security.saml2.relyingparty.registration.simplesamlphp.name-id-format", "sampleNameIdFormat");
assertThat(this.properties.getRegistration().get("simplesamlphp").getNameIdFormat())
.isEqualTo("sampleNameIdFormat");
}

private void bind(String name, String value) {
bind(Collections.singletonMap(name, value));
}
Expand Down

0 comments on commit e70d127

Please sign in to comment.