-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset Password API v2 endpoints #490
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
33 changes: 33 additions & 0 deletions
33
app/controllers/spree/api/v2/storefront/passwords_controller.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
module Spree | ||
module Api | ||
module V2 | ||
module Storefront | ||
class PasswordsController < ::Devise::PasswordsController | ||
def create | ||
user = Spree.user_class.find_by(email: params[:user][:email]) | ||
|
||
if user&.send_reset_password_instructions | ||
head :ok | ||
else | ||
head :not_found | ||
end | ||
end | ||
|
||
def update | ||
user = Spree.user_class.reset_password_by_token( | ||
password: params[:user][:password], | ||
password_confirmation: params[:user][:password_confirmation], | ||
reset_password_token: params[:id] | ||
) | ||
|
||
if user.errors.empty? | ||
head :ok | ||
else | ||
render json: { error: user.errors.full_messages.to_sentence }, status: :unprocessable_entity | ||
end | ||
end | ||
end | ||
end | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 changes: 62 additions & 0 deletions
62
spec/controllers/spree/api/v2/storefront/passwords_controller_spec.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
RSpec.describe Spree::Api::V2::Storefront::PasswordsController, type: :controller do | ||
let(:user) { create(:user) } | ||
let(:password) { 'new_password' } | ||
|
||
describe 'POST create' do | ||
before { post :create, params: params } | ||
|
||
context 'when the user email has not been specified' do | ||
let(:params) { { user: { email: '' } } } | ||
it 'responds with not found status' do | ||
expect(response.code).to eq('404') | ||
end | ||
end | ||
|
||
context 'when the user email not found' do | ||
let(:params) { { user: { email: '[email protected]' } } } | ||
it 'responds with not found status' do | ||
expect(response.code).to eq('404') | ||
end | ||
end | ||
|
||
context 'when the user email has been specified' do | ||
let(:params) { { user: { email: user.email } } } | ||
it_behaves_like 'returns 200 HTTP status' | ||
end | ||
end | ||
|
||
describe 'PATCH update' do | ||
before { patch :update, params: params } | ||
|
||
context 'when updating password with blank password' do | ||
let(:params) { | ||
{ | ||
id: user.send_reset_password_instructions, | ||
user: { | ||
password: '', | ||
password_confirmation: '' | ||
} | ||
} | ||
} | ||
|
||
it 'responds with error' do | ||
expect(response.code).to eq('422') | ||
expect(JSON.parse(response.body)['error']).to eq("Password can't be blank") | ||
end | ||
end | ||
|
||
context 'when updating password with specified password' do | ||
let(:params) { | ||
{ | ||
id: user.send_reset_password_instructions, | ||
user: { | ||
password: password, | ||
password_confirmation: password | ||
} | ||
} | ||
} | ||
|
||
it_behaves_like 'returns 200 HTTP status' | ||
end | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we just return head, not json?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@damianlegawiec wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chhga @pmilewski head is OK