Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset Password API v2 endpoints #490

Merged
merged 3 commits into from
May 21, 2020
Merged

Reset Password API v2 endpoints #490

merged 3 commits into from
May 21, 2020

Conversation

pmilewski
Copy link
Member

No description provided.

@pmilewski pmilewski force-pushed the reset-password-api-v2-endpoints branch 3 times, most recently from 5ea570d to b96f728 Compare May 20, 2020 10:22
@pmilewski pmilewski marked this pull request as ready for review May 20, 2020 10:36
chhlga
chhlga reviewed May 20, 2020
View reviewed changes
app/controllers/spree/api/v2/storefront/passwords_controller.rb
)

if user.errors.empty?
head :ok
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we just return head, not json?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we just return head, not json?

@damianlegawiec wdyt?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chhga @pmilewski head is OK

@pmilewski pmilewski force-pushed the reset-password-api-v2-endpoints branch from b96f728 to c8c5ca3 Compare May 20, 2020 11:37
@damianlegawiec
Merge pull request #52 from spree/master
91ac251 
[pull] master from spree:master
@damianlegawiec
Merge pull request #53 from spree/master
5d1b24e 
[pull] master from spree:master
@pmilewski pmilewski force-pushed the reset-password-api-v2-endpoints branch from c8c5ca3 to 1956196 Compare May 21, 2020 07:28
@pmilewski pmilewski requested a review from damianlegawiec May 21, 2020 07:30
@damianlegawiec damianlegawiec merged commit 777b63b into master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chhlga chhlga chhlga approved these changes

@damianlegawiec damianlegawiec damianlegawiec approved these changes

@btolarz btolarz Awaiting requested review from btolarz

@kgorazd kgorazd Awaiting requested review from kgorazd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmilewski @damianlegawiec @chhlga