Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return id(s) when calling Index::addItem and Index::addItems in Java bindings #94

Merged
merged 8 commits into from
Dec 13, 2024

Conversation

stephen29xie
Copy link
Contributor

@stephen29xie stephen29xie commented Oct 14, 2024

Description

In C++ and Python, the id of the item(s) are returned when they are added to the index. In Java, these methods return void. This PR brings these to parity.

Related Issues

#84

Changes Made

Java

  • Return id(s) when calling Index::addItem and Index::addItems in Java bindings.
  • Update docs
  • Update tests

Testing

Checklist

  • My code follows the code style of this project.
  • I have added and/or updated appropriate documentation (if applicable).
  • All new and existing tests pass locally with these changes.
  • I have run static code analysis (if available) and resolved any issues.
  • I have considered backward compatibility (if applicable).
  • I have confirmed that this PR does not introduce any security vulnerabilities.

Additional Comments

@stephen29xie stephen29xie marked this pull request as ready for review October 16, 2024 17:46
Copy link
Member

@psobot psobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two suggestions. Thanks!

@stephen29xie stephen29xie requested a review from psobot December 13, 2024 17:00
@stephen29xie stephen29xie merged commit d68175e into main Dec 13, 2024
57 checks passed
@stephen29xie stephen29xie deleted the stephenx/java-add-items branch December 13, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants