Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return ids when adding item(s) to index in Java #84

Closed
stephen29xie opened this issue Aug 26, 2024 · 1 comment
Closed

Return ids when adding item(s) to index in Java #84

stephen29xie opened this issue Aug 26, 2024 · 1 comment
Assignees
@stephen29xie
Labels
enhancement New feature or request

Comments

@stephen29xie
Copy link
Contributor

In C++ and Python, the ids of the item(s) are returned when they are added to the index. In Java, those methods return void. We should modify Index::addItem and Index::addItems to return the ids in Java too.
@stephen29xie stephen29xie added the enhancement New feature or request label Aug 26, 2024
@stephen29xie stephen29xie self-assigned this Sep 4, 2024
@stephen29xie stephen29xie mentioned this issue Oct 15, 2024
Merged
6 tasks
@stephen29xie
Copy link
Contributor Author

Completed in #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephen29xie stephen29xie

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stephen29xie