This repository has been archived by the owner on Sep 12, 2024. It is now read-only.
Upgrade docker-client dep from 8.9.0 to 8.9.2 #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to resolve transitive dep conflict on jnr-unixsocket via docker-client. Newer version of ssh-agent-proxy uses same version 0.18 of jnr-unixsocket as docker-client. Move jnr-unixsocket and ssh-agent-proxy deps to parent's dep management. depends on spotify/ssh-agent-proxy#7
davidxia
force-pushed
the
dxia/upgrade-docker-client
branch
from
e2a796e to
78280e1
Compare
Codecov Report
@@ Coverage Diff @@
## master #1190 +/- ##
============================================
+ Coverage 52.51% 52.54% +0.03%
Complexity 1609 1609
============================================
Files 268 268
Lines 13005 13004 -1
Branches 1501 1502 +1
============================================
+ Hits 6829 6833 +4
+ Misses 5655 5650 -5
Partials 521 521 |
|
Tests now pass. |
caipre
approved these changes
Nov 16, 2017
mattnworb
approved these changes
Nov 20, 2017
|
In general my motivation for upgrades like this is to not fall too far behind upstream. I don't like having to upgrade in cases like this where we don't need any of the new features and upgrading presents a little bit of risk. But my other fear of not tracking upstream is the scenario where we need to fix a bug in docker-client, then if we're really far behind it's scarier to upgrade. Not sure if there's a solution better than incrementally upgrading. |
|
I'll merge after Thanksgiving break. |
ghost
pushed a commit
that referenced
this pull request
Dec 8, 2017
Upgrade docker-client dep from 8.9.0 to 8.9.2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on spotify/docker-client#922