This repository has been archived by the owner on Mar 21, 2022. It is now read-only.
Upgrade maven-shade-plugin from 2.4.1 to 3.1.0 #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #922 +/- ##
=========================================
Coverage 66.04% 66.04%
Complexity 769 769
=========================================
Files 171 171
Lines 3240 3240
Branches 369 369
=========================================
Hits 2140 2140
Misses 940 940
Partials 160 160 |
and use ServicesResourceTransformer to relocate class names in META-INF/services/. fixes #900
davidxia
force-pushed
the
dxia/upgrade-shade-plugin
branch
from
a2fe9c4 to
bfc400c
Compare
davidxia
added a commit
to spotify/helios
that referenced
this pull request
Nov 13, 2017
This was referenced Nov 13, 2017
caipre
approved these changes
Nov 14, 2017
mattnworb
approved these changes
Nov 15, 2017
|
Sorry, just seeing this -- but looks good from what I can tell. |
|
Sorry for the delay. Problem solved. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and use ServicesResourceTransformer to relocate class names in
META-INF/services/.
fixes #900