Skip to content
This repository has been archived by the owner on Mar 21, 2022. It is now read-only.

Upgrade guava from 18 to 20 #849

Closed
wants to merge 2 commits into from
Closed

Upgrade guava from 18 to 20 #849

wants to merge 2 commits into from

Conversation

davidxia
Copy link
Contributor

fixes #826

@davidxia davidxia changed the title Upgrade guava from 18 to 22 Upgrade guava from 18 to 20 Jul 29, 2017
@davidxia
Copy link
Contributor Author

just testing do not merge

@codecov-io
Copy link

codecov-io commented Jul 29, 2017

Codecov Report

Merging #849 into master will not change coverage.
The diff coverage is 50%.

@@            Coverage Diff            @@
##             master     #849   +/-   ##
=========================================
  Coverage     66.37%   66.37%           
+ Complexity      743      742    -1     
=========================================
  Files           166      166           
  Lines          3138     3138           
  Branches        357      357           
=========================================
  Hits           2083     2083           
  Misses          898      898           
  Partials        157      157

@mattnworb
Copy link
Member

Would be nice to start relocating the guava classes before we do another upgrade, as this sort of change has a big effect on all downstream users of this and/or helios-client, helios-testing etc. See spotify/helios#1119 for instance.

@mattnworb
Copy link
Member

Also I wonder if after we upgrade this library to require Java 8 if we could ditch guava altogether, as it is a large dependency to be dragging into user's projects.

davidxia added 2 commits July 29, 2017 14:48
to avoid class conflicts with other guava versions.

Fixes #826
@davidxia
Copy link
Contributor Author

davidxia commented Aug 4, 2017

Closing as there are already two other PRs that do what this one does. #792 upgrades to guava 20, and #850 shades and relocates guava.

@davidxia davidxia closed this Aug 4, 2017
@davidxia davidxia deleted the dxia/guava-20 branch August 4, 2017 23:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Old Guava used, causes NoSuchMethodError with Guava 22.0
3 participants