Skip to content
This repository has been archived by the owner on Mar 21, 2022. It is now read-only.

Upgrade guava to 20.0 #792

Conversation

lukasniemeier-zalando
Copy link
Contributor

This upgrades the guava dependency to the latest Java 7 compatible version, allowing the usage of recent guava libraries in projects using docker-client. The version currently used (18.0) is 3 years old.

After merge docker-client needs guava >= 20.0, see here.

Further upgrades depend on #756 😉

@lukasniemeier-zalando
Copy link
Contributor Author

lukasniemeier-zalando commented Jun 12, 2017

Build is only failing for docker 1.10.3, but seems to be the case for all builds.

@codecov-io
Copy link

codecov-io commented Jul 29, 2017

Codecov Report

Merging #792 into master will not change coverage.
The diff coverage is 50%.

@@            Coverage Diff            @@
##             master     #792   +/-   ##
=========================================
  Coverage     66.46%   66.46%           
  Complexity      745      745           
=========================================
  Files           166      166           
  Lines          3140     3140           
  Branches        357      357           
=========================================
  Hits           2087     2087           
  Misses          898      898           
  Partials        155      155

davidxia
davidxia previously approved these changes Aug 4, 2017
Copy link
Contributor

@davidxia davidxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@mattnworb mattnworb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! One minor thing: would you mind updating the CHANGELOG too?

@davidxia : I'd like if we can merge this after #850 is done, to combine these two changes

@lukasniemeier-zalando
Copy link
Contributor Author

One minor thing: would you mind updating the CHANGELOG too?

@mattnworb done.

@davidxia
Copy link
Contributor

davidxia commented Aug 8, 2017

I rebased on master here #860

@davidxia davidxia closed this Aug 8, 2017
@lukasniemeier-zalando lukasniemeier-zalando deleted the uprade-guava branch August 8, 2017 07:02
@mattnworb
Copy link
Member

Thanks @davidxia

@lukasniemeier-zalando the merge conflict is because the CHANGELOG file on master at the time of your edit was out of date and still referred to 8.8.1 as the "not yet released" version even though 8.8.3 had been released. Thanks again for the PR!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants