-
Notifications
You must be signed in to change notification settings - Fork 549
Add support for runtime property in HostConfig #1060
Conversation
This is a continuation of #1053 as parts of docker-client were still using exit code of Integer. This caused some uses to have inconsistent types.
This commit introduces `runtime` property to HostConfig.
Change of exitCode from Integer to Long is a break change.
is the stuff about exit codes related to #1053 ? also, can you update the CHANGELOG file? |
Codecov Report
@@ Coverage Diff @@
## master #1060 +/- ##
============================================
+ Coverage 67.32% 67.38% +0.06%
Complexity 795 795
============================================
Files 178 178
Lines 3287 3287
Branches 385 385
============================================
+ Hits 2213 2215 +2
+ Misses 911 910 -1
+ Partials 163 162 -1 |
the change itself LGTM 👍 |
👍 |
Yes. The mismatch in exit code was breaking code in helios.
👍Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What you've changed LGTM. But I request one additional change from Integer
to Long
on ContainerStatus.exitCode
.
CHANGELOG.md
Outdated
@@ -1,5 +1,13 @@ | |||
# Changelog | |||
|
|||
## 9.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know that a bump all the way up to version 9.0.0
is required. 8.13.0
seems more appropriate to me.
CHANGELOG.md
Outdated
@@ -1,5 +1,13 @@ | |||
# Changelog | |||
|
|||
## 9.0.0 | |||
|
|||
Released August 29 2018 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change this to "Not yet released"? The date should be set when the release is made.
9ea2db6
to
5a27e80
Compare
@johnflavin That's already part of this PR: And thanks for the feedback 😃 |
This PR:
nvidia