This repository has been archived by the owner on Mar 21, 2022. It is now read-only.
Change ContainerState.exitCode from Integer to Long #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated CHANGELOG and bumped minor version. see #1052
Codecov Report
@@ Coverage Diff @@
## master #1053 +/- ##
=========================================
Coverage 67.37% 67.37%
Complexity 774 774
=========================================
Files 176 176
Lines 3234 3234
Branches 368 368
=========================================
Hits 2179 2179
Misses 898 898
Partials 157 157 |
mattnworb
approved these changes
Aug 22, 2018
vbhavsar
pushed a commit
to spotify/helios
that referenced
this pull request
Aug 28, 2018
This is a continuation of spotify/docker-client#1053 as parts of docker-client were still using exit code of Integer. This caused some uses to have inconsistent types.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated CHANGELOG and bumped minor version.
see #1052