fix: added partial support for CONSTANT_Dynamic #2512
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Class files using condy (Dynamic class-file constant), like JaCoCo >= 0.8.4
creates them (see [1] and [2] for more details), causes errors we using
Spotbugs to parse these class files.
The `FooWithMember.clazz` embedded in this commit has been generated
from this class source file:
```java
package com.foo;
class Foo {
int a;
public Foo(int a) {
this.a = a;
}
public int getA() {
return this.a;
}
}
```
These modifications don't completely fix the support of `CONSTANT_Dynamic`.
We continue to have error from BCEL (maybe [3] is insufficient):
```
Exception analyzing com.foo.Foo using detector edu.umd.cs.findbugs.detect.FindNullDeref
java.lang.IllegalArgumentException: Unknown or invalid constant type at 32
At org.apache.bcel.generic.LDC.getValue(LDC.java:113)
At edu.umd.cs.findbugs.ba.vna.ValueNumberFrameModelingVisitor.visitLDC(ValueNumberFrameModelingVisitor.java:529)
At org.apache.bcel.generic.LDC.accept(LDC.java:58)
At edu.umd.cs.findbugs.ba.AbstractFrameModelingVisitor.analyzeInstruction(AbstractFrameModelingVisitor.java:84)
At edu.umd.cs.findbugs.ba.vna.ValueNumberAnalysis.transferInstruction(ValueNumberAnalysis.java:228)
At edu.umd.cs.findbugs.ba.vna.ValueNumberAnalysis.transferInstruction(ValueNumberAnalysis.java:57)
At edu.umd.cs.findbugs.ba.AbstractDataflowAnalysis.transfer(AbstractDataflowAnalysis.java:136)
At edu.umd.cs.findbugs.ba.vna.ValueNumberAnalysis.transfer(ValueNumberAnalysis.java:214)
At edu.umd.cs.findbugs.ba.vna.ValueNumberAnalysis.transfer(ValueNumberAnalysis.java:57)
At edu.umd.cs.findbugs.ba.Dataflow.execute(Dataflow.java:378)
At edu.umd.cs.findbugs.classfile.engine.bcel.ValueNumberDataflowFactory.analyze(ValueNumberDataflowFactory.java:76)
At edu.umd.cs.findbugs.classfile.engine.bcel.ValueNumberDataflowFactory.analyze(ValueNumberDataflowFactory.java:46)
At edu.umd.cs.findbugs.classfile.impl.AnalysisCache.analyzeMethod(AnalysisCache.java:368)
At edu.umd.cs.findbugs.classfile.impl.AnalysisCache.getMethodAnalysis(AnalysisCache.java:321)
At edu.umd.cs.findbugs.classfile.engine.bcel.AnalysisFactory.getValueNumberDataflow(AnalysisFactory.java:118)
At edu.umd.cs.findbugs.classfile.engine.bcel.TypeDataflowFactory.analyze(TypeDataflowFactory.java:73)
At edu.umd.cs.findbugs.classfile.engine.bcel.TypeDataflowFactory.analyze(TypeDataflowFactory.java:43)
At edu.umd.cs.findbugs.classfile.impl.AnalysisCache.analyzeMethod(AnalysisCache.java:368)
At edu.umd.cs.findbugs.classfile.impl.AnalysisCache.getMethodAnalysis(AnalysisCache.java:321)
At edu.umd.cs.findbugs.classfile.engine.bcel.CFGFactory.analyze(CFGFactory.java:160)
At edu.umd.cs.findbugs.classfile.engine.bcel.CFGFactory.analyze(CFGFactory.java:65)
At edu.umd.cs.findbugs.classfile.impl.AnalysisCache.analyzeMethod(AnalysisCache.java:368)
At edu.umd.cs.findbugs.classfile.impl.AnalysisCache.getMethodAnalysis(AnalysisCache.java:321)
At edu.umd.cs.findbugs.classfile.engine.bcel.AnalysisFactory.getCFG(AnalysisFactory.java:93)
At edu.umd.cs.findbugs.classfile.engine.bcel.DepthFirstSearchFactory.analyze(DepthFirstSearchFactory.java:49)
At edu.umd.cs.findbugs.classfile.engine.bcel.DepthFirstSearchFactory.analyze(DepthFirstSearchFactory.java:32)
At edu.umd.cs.findbugs.classfile.impl.AnalysisCache.analyzeMethod(AnalysisCache.java:368)
At edu.umd.cs.findbugs.classfile.impl.AnalysisCache.getMethodAnalysis(AnalysisCache.java:321)
At edu.umd.cs.findbugs.classfile.engine.bcel.AnalysisFactory.getDepthFirstSearch(AnalysisFactory.java:98)
At edu.umd.cs.findbugs.classfile.engine.bcel.ValueNumberDataflowFactory.analyze(ValueNumberDataflowFactory.java:68)
At edu.umd.cs.findbugs.classfile.engine.bcel.ValueNumberDataflowFactory.analyze(ValueNumberDataflowFactory.java:46)
At edu.umd.cs.findbugs.classfile.impl.AnalysisCache.analyzeMethod(AnalysisCache.java:368)
At edu.umd.cs.findbugs.classfile.impl.AnalysisCache.getMethodAnalysis(AnalysisCache.java:321)
At edu.umd.cs.findbugs.ba.ClassContext.getMethodAnalysis(ClassContext.java:1010)
At edu.umd.cs.findbugs.ba.ClassContext.getValueNumberDataflow(ClassContext.java:333)
At edu.umd.cs.findbugs.detect.FindNullDeref.findPreviouslyDeadBlocks(FindNullDeref.java:301)
At edu.umd.cs.findbugs.detect.FindNullDeref.analyzeMethod(FindNullDeref.java:271)
At edu.umd.cs.findbugs.detect.FindNullDeref.visitClassContext(FindNullDeref.java:216)
At edu.umd.cs.findbugs.DetectorToDetector2Adapter.visitClass(DetectorToDetector2Adapter.java:76)
At edu.umd.cs.findbugs.FindBugs2.lambda$analyzeApplication$1(FindBugs2.java:1108)
At java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
At edu.umd.cs.findbugs.CurrentThreadExecutorService.execute(CurrentThreadExecutorService.java:86)
At java.base/java.util.concurrent.AbstractExecutorService.invokeAll(AbstractExecutorService.java:247)
At edu.umd.cs.findbugs.FindBugs2.analyzeApplication(FindBugs2.java:1118)
At edu.umd.cs.findbugs.FindBugs2.execute(FindBugs2.java:309)
At edu.umd.cs.findbugs.FindBugs.runMain(FindBugs.java:395)
```
[1]: jacoco/jacoco@36b4e9c#diff-1d450b7247672d9362bac0ad7dfd7bd810e4293ab57f0100821a70a5e64e6911R56-R57
[2]: jacoco/jacoco#845
[3]: https://issues.apache.org/jira/browse/BCEL-362
ghost
mentioned this pull request
|
There are some problems with the BCEL update currently. The errors in spotbugs will get fixed with #2278, but to merge it we need a new bcel release with apache/commons-bcel#221 merged. Can you please check if the changes from these two PRs solve the problem? (The bcel dependency needed to be modified to snapshot, because of the latter PR.) |
|
Same problem with bcel On the master branch, the method org/apache/bcel/generic/LDC::getValue() doesn't support |
Then there is a bcel issue as well. Can you please open an issue to them about this? |
|
Mmm My knowledge of Java / JaCoCo / ASM / bcel are very limited. I don't able to explain how If needed, I updated the issue #2503 with the Java source code and the class file generated by Java 17 + JaCoCo 0.8.9 which is causing problems. |
JuditKnoll
approved these changes
Oct 10, 2023
| @@ -113,12 +114,16 @@ private void assertHasCodeBase(IScannableCodeBase codeBase) throws Exception { | |||
|
|
|||
| @Test | |||
| public void acceptConstantDynamic() throws Exception { | |||
| String fileName = "../spotbugsTestCases/src/classSamples/recordCompileWithBazel6.2/Foo.clazz"; | |||
| ArrayList<String> fileNames = new ArrayList<>(); | |||
There was a problem hiding this comment.
Could you please add a comment about the class files (how to recreate them), and refer the issue here?
JuditKnoll
requested changes
Oct 13, 2023
ghost
closed this by deleting the head repository
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class files using condy (Dynamic class-file constant), like JaCoCo >= 0.8.4 creates them (see 36b4e9c7 and #845 for more details), causes errors we using Spotbugs to parse these class files.
The
FooWithMember.clazzembedded in this commit has been generated from this class source file:These modifications don't completely fix the support of
CONSTANT_Dynamic. We continue to have error from BCEL (maybe #BCEL-362 is insufficient):Issue: #2503