Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Graphs to Statistics Tab (Issue #136) #698

Closed

Conversation

mmushtaq201
Copy link

@mmushtaq201 mmushtaq201 commented Nov 23, 2020

Fixes # 136 https://github.com/spiral-project/ihatemoney/issues/136

This pull request involves code for Issue 'Display statistics as a graph #136'. Details of the implementation is as follows:

  1. Two graphs have been implemented using AnyChart - JS charts.
  2. First Graph displays statistics of total money spent by each participant for a given the project.
  3. Second Graph displays statistics of the combined monthly expenditures of all the participants for a given project.
  4. Changes reside only in the .html files:
  • statistics.html
  • layout.html
  1. To my knowledge, there is no impact on the existing functionality of the project.

Existing Project Credentials for ready to view graphs.
Project Identifier: test
Project code: admin1234

1
2

@Glandos
Copy link
Member

Glandos commented Nov 24, 2020

AnyChart is probably a good product but it requires a license.

I can't speak for other members, but I am personally against its integration for this reason.

@zorun
Copy link
Collaborator

zorun commented Nov 28, 2020

Thanks for working on this!

I'm not sure the first one brings a lot of useful information, but the second one is good. How does the user choose which one to display?

And indeed, it seems that AnyChart is not free software. We probably cannot use it without asking for a special license and I don't like that either.

@almet
Copy link
Member

almet commented Apr 7, 2021

I'm closing this in favor of the most recent #731 attempt with another library.

@almet almet closed this Apr 7, 2021
@almet
Copy link
Member

almet commented Apr 7, 2021

But, let me stress this out : thanks a lot @mmushtaq201 for working on this. That's appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants