-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display statistics as a graph #136
Comments
What would that look like? |
That's really cool! I think we could even provide this information as a graph (Diverging stacked bar chart) |
Having a graph for statistics would be very nice, and probably not that hard to do, I can give it a try :) I think this kind of simple line chart would be easier to read: http://www.chartjs.org/samples/latest/charts/line/basic.html One practical question though: would it be better to use the API with Ajax queries, or just write a view that generates the necessary data? |
@zorun thank you for your message and welcome to this project. I don't think the project already have a REST API, so if you were to build one, it would be a bit of work. (CORS, Auth, utilities, documentation). Also it might be a interesting project to build one. For now, I guess having a django rendered view would be good enough. I am usually using a project per trip (with family and friends) and I don't need the monthly feature but more a total of all the expenses. Last time I also wanted some metrics about how much was spend for the car, how much for the accomodation and how much for food and tourism. |
Hi @Natim There are already such statistics shown in a table, from #257 :) see for instance https://ihatemoney.org/demo/statistics Regarding the API, I was thinking of using this one https://ihatemoney.readthedocs.io/en/latest/api.html |
@zorun we never actually answered you! I think the best way to go is to integrate the Javascript in a view to be served directly by the python app. While this method is subject to discussion, it's the way all the project is currently built, so we better stick with it for clarity :-) If you want to work on this (or if anyone wants), don't hesitate, that would be a welcome addition! Cheers! |
It seems this feature is still looking for somebody to implement it :-) |
Yes, I never went around to try something, feel free to pick this up :) For now I'm producing graphs "offline" with a custom json-to-gnuplot conversion script, but it would definitely be better to have it integrated in IHM! |
Can I work on this? |
@CubixPro yes, you can start working on this. |
Should I use Canvasjs.js or google charts? And where can I send the prototypes? |
It seems that CanvasJS requires a licence. Google Charts requires loading from Google servers, so it's also a non-goal for this project. However, there are a lot (too much?) other libraries that can fit. For example C3.js that is based on D3. It's maybe missing some features but I don't think we need them. Or, if you find a missing use case, please tell us :) For prototypes, you can simply start but sending screenshot in this thread. You can drag'n'drop images right in the comment text field, and GitHub will upload it for you. |
Okay sure thanks. I'll look into this and let you know :) |
Hi guys, is this still open? Can I work on this issue? :) |
I can't believe I waited so long to answer to you, @thejacobx. If you are still opened to contribution, you can start on it. |
I am hoping that the 3rd time would be a charm with this issue and checking whether it is still available. I am willing to take it up. |
Hi, I would like to work on this issue, is it stil available? |
Hello I will work on this! |
Play thanks ! Let us know if you need help
…Hello I will work on this!
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#136 (comment)
|
Hi Spiral-Project/Ihatemoney,
Thanks for the feedback. I am planning to use
a Python Graph Library like Seaborn or GGPlot, both are open source,
and I used those quite a lot and would feel comfortable with it.
I would appreciate any further useful guideline you may want to give me.
Thanks and regards,
Carlos
…On Wed, Oct 20, 2021 at 11:31 AM Alexis Metaireau ***@***.***> wrote:
Play thanks ! Let us know if you need help
|
Please, have a look at the existing PR at #731. good stuff there, it was abandoned but you probably could build on top of it. |
Hello Alexis.
Thanks for the tip, I have looked and it became more clear to me.
Kind regards,
Carlos
…On Wed, Oct 20, 2021 at 10:50 PM Alexis Metaireau ***@***.***> wrote:
Please, have a look at the existing PR at #731
<#731>. good stuff
there, it was abandoned but you probably could build on top of it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#136 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMXPHE3SUNN2AIO6GYDELMLUH42SXANCNFSM4B2KSYUA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Hello Guys.
Sorry for not giving any feedback yet.
I was pretty tight on time working on 2 startup projects plus Google MWS
track and
a mobile internship. I am pretty much done with both study projects so I
was trying to tackle
the #736 graph stats issue.
I am not quite familiar with flask, so I forked the repo, cloned it and
installed
missing flask dependencies however I can't launch the app. I know is
probably something
very simple, the thing is I am good with ML and Statistics with scikit, and
so on but I want to see first how the api is working right now then I can,
make the additions in the models.py or
other files.
I am keen to tackle this one and keep learning
On Thu, Oct 21, 2021 at 6:03 PM Carlos Pimentel_leanTech <
***@***.***> wrote:
… Hello Alexis.
Thanks for the tip, I have looked and it became more clear to me.
Kind regards,
Carlos
On Wed, Oct 20, 2021 at 10:50 PM Alexis Metaireau <
***@***.***> wrote:
> Please, have a look at the existing PR at #731
> <#731>. good stuff
> there, it was abandoned but you probably could build on top of it.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#136 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AMXPHE3SUNN2AIO6GYDELMLUH42SXANCNFSM4B2KSYUA>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
|
Hey, cool to have you onboard :-) I can try helping you the best I can. Can you please post some information so I can try debug the situation? You could for instance put the error message here, and maybe a stacktrace? Also, the best way to do this would be to open a new issue to help you getting started, in order to keep the history of this issue clear! Cheers. |
A statistics page (as requested initially) has been added a long time ago. There have been several attempts at adding graphs but none went through. Ihatemoney is currently very lightweight regarding javascript (I believe we only have javascript from bootstrap), and this is something we want to keep, see https://ihatemoney.readthedocs.io/en/latest/contributing.html#current-direction-as-of-2024 As mentioned by @Glandos in #1011, one way to go would be to use pygal and its Flask integration. I am closing this ticket because it is not a priority of the project, but a simple proposal using pygal and good UI/UX integration would definitely be considered for inclusion. |
It could be nice to have a summary tab with information about what everybody did pay and did spend as well as the total of expenses for the group.
The text was updated successfully, but these errors were encountered: