-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Add github action for building doc #8
Conversation
I have not seen a way to make actions take effect in the PR that adds them. Probably worth looking into if you want to test this. Otherwise you'll be stuck actually pushing a branch to this repo (rather than your own) which is annoying. Actually I guess you could just look here: https://github.com/lucyleeow/sample-project/actions I'd recommend enabling Actions debug mode on your repo, too |
@larsoner I wasn't sure how best to name the github action workflow .yml file. I called it I used the community workflows sphinx build action and upload artifacts - reasonable? Otherwise good to go. |
I would use whatever is most common + easy + supported, sounds like these probably are One thing that is missing is some sort of status update, is there a GitHub action to make a link to one of the artifacts that is produced by the https://github.com/larsoner/circleci-artifacts-redirector-action |
I don't think there is a way to do that: https://github.community/t5/GitHub-Actions/Link-to-latest-artifacts/td-p/36394 Further you can only download the artifact, and cannot get a link to view the html pages directly. And there does not even seem to be a way to get a link to download the uploaded artifact - actions/upload-artifact#27 |
These seem like pretty bad deficiencies compared to CircleCI to the point where I would not recommend people use GitHub actions... |
I agree. Maybe we can table this until this feature is added? @GaelVaroquaux feel free to pitch in. |
FYI I'm fine with merging this as is, too, so long as we add some comment noting the limitations we've hit. It's still useful to have as a template in case people don't care about the limitation, or if at some point we figure out how to get around it. |
I don't mind either way. I'm working on some documentation in |
Merging this and noting limitations in readme |
wait @larsoner didn't you build a github actions bot just to do this very thing? |
For CircleCI artifacts yes, not for GitHub actions artifacts |
Ohhh I see - I thought that https://github.com/larsoner/circleci-artifacts-redirector-action was doing this, but I guess that's just an action to look at the CircleCI artifacts, not to point to GHA artifacts |
closes #7