-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TESTS: Try to fix CI #361
TESTS: Try to fix CI #361
Conversation
pytest-sugar currently doesn't support pytest 5.4, see Teemu/pytest-sugar#187
@hoechenberger maybe Line 20 in 71520d6
|
Thanks @hoechenberger! Travis fails because it wants you to keep |
Thanks @sappelhoff and @GuillaumeFavelier |
we should migrate CIs from appveyor to azure pipelines as it's much faster for windows any objection? |
None from my side, but I've never created an Azure pipeline before, so would need a little time to get this to work. Or sb else would have to do it :) |
No objection, but perhaps it can be done the next time we have issues with the CIs ... currently it's working so we can just leave it as they are? |
it's working but it slows down feedback on PRs
to be done when someone needs to procrastinate
|
thx @hoechenberger |
@agramfort @hoechenberger .. coming back to the CI discussion and moving Appveyor --> Azure Pipelines. It might be possible that we can test Linux, MacOS, and Windows all using GitHub Actions (https://github.com/features/actions) Just to keep in mind. Maybe @larsoner knows more about this? |
I hear good things about github actions but never played with it
… |
Yes you can probably go either way. I have limited direct experience with GitHub actions. It does seem to have some annoying limitations. My guess is that Azure will be easier because there are many existing repos using it that you could use to build up an appropriate |
I would keep circle for the doc. Just get it of appveyor which is too slow
… |
I would stay away from github actions for now. Not sure how mature it is ... |
PR Description
pytest-sugar currently doesn't support pytest 5.4, see Teemu/pytest-sugar#187
Pinning pytest to <5.4 for now to hopefully make CIs work again.
Merge checklist
Maintainer, please confirm the following before merging: