Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Add support for IJ 2021.3 #988

Closed
wants to merge 4 commits into from

Conversation

jurriaan
Copy link

@jurriaan jurriaan commented Dec 9, 2021

Upgrade plugin's supporting versions following the release of IDEA 2021.3

Based on #977

Upgrade plugin's supporting versions following the release of `IDEA 2021.3`

Based on spekframework#977
"IJ2021.3",
"IJ183",
ij.VersionRange("213.1", "213.*"),
arrayOf("java", "org.jetbrains.kotlin:211-1.4.32-release-IJ6693.72")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed this isn't the correct version, looking for the correct version number

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

213-1.6.10-release-923-IJ5744.223 maybe?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

org.jetbrains.kotlin:211-1.4.21-release-IJ6693.43 should still work. Apologies for the delay, I barely have time to work on personal projects nowadays. If you know someone who wants to take over the project, please let me know!

Copy link

@joelhandwell joelhandwell Dec 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hhariri @jonnyzzz @mhshams @orangy @lkogler any idea for taking over the project (possibly by JetBrains)?

@jggomez
Copy link

jggomez commented Dec 20, 2021

Please, updated to latest version

@CriPstian
Copy link

Hello 👋 Can we merge this PR? It looks like everything should be fine, or am I missing something? Thanks for this BTW 👍
@raniejade is it still up to you to move this forward? How could we help out?

@jurriaan
Copy link
Author

jurriaan commented Feb 9, 2022

@CriPstian Unfortunately the PR in the current state is broken.

I can't get it to compile properly, even with the version constraint here (#988 (comment). It needs to use a later version of the org.jetbrains.kotlin plugin. since that plugin is not compatible with the latest intellij anymore.

@CriPstian
Copy link

@jurriaan The failure might be related to Jetbrains moving away from bintray.
I knew about bintray being deprecated so now I can see that this build always fails with the same 502 bad gateway.
I believe there should be another task to move to the new repositories, and only then we can move forward with this PR 😢
Hope this helps in any way.

@jurriaan
Copy link
Author

jurriaan commented Feb 10, 2022

@CriPstian That issue was fixable by removing the bintray repos from the gradle files (it looks like those dependencies are now available on maven), the issue I'm having now is more around compilation of the project with a newer version of org.jetbrains.kotlin, version 1.6.x instead of 1.4.x

To me building a zip file that I can manually install in IntelliJ would be very helpful already, but indeed, the spek artifacts should also be moved to a different repository.

@CriPstian
Copy link

@jurriaan There is also the need to upgrade gradle version as it comes with it's own bundled kotlin version. Also, tried to upgrade throughout the project where kotlin was mentioned.
Also, I did it locally on your branch and had difficulties bringing the spek-ide-plugin-intellij-idea-base dependency on the classpath :(
Hope this helps

@raniejade
Copy link
Member

Closing this in favor of #991. Thanks all for the contribution!

@raniejade raniejade closed this Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants