-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.x] Add support for IJ 2021.3 #988
Conversation
Upgrade plugin's supporting versions following the release of `IDEA 2021.3` Based on spekframework#977
"IJ2021.3", | ||
"IJ183", | ||
ij.VersionRange("213.1", "213.*"), | ||
arrayOf("java", "org.jetbrains.kotlin:211-1.4.32-release-IJ6693.72") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed this isn't the correct version, looking for the correct version number
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
213-1.6.10-release-923-IJ5744.223
maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
org.jetbrains.kotlin:211-1.4.21-release-IJ6693.43
should still work. Apologies for the delay, I barely have time to work on personal projects nowadays. If you know someone who wants to take over the project, please let me know!
Please, updated to latest version |
Hello 👋 Can we merge this PR? It looks like everything should be fine, or am I missing something? Thanks for this BTW 👍 |
@CriPstian Unfortunately the PR in the current state is broken. I can't get it to compile properly, even with the version constraint here (#988 (comment). It needs to use a later version of the |
@jurriaan The failure might be related to |
@CriPstian That issue was fixable by removing the bintray repos from the gradle files (it looks like those dependencies are now available on maven), the issue I'm having now is more around compilation of the project with a newer version of To me building a zip file that I can manually install in IntelliJ would be very helpful already, but indeed, the spek artifacts should also be moved to a different repository. |
@jurriaan There is also the need to upgrade |
Closing this in favor of #991. Thanks all for the contribution! |
Upgrade plugin's supporting versions following the release of
IDEA 2021.3
Based on #977