Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Add support for IJ 2021.2 #977

Merged
merged 2 commits into from
Aug 5, 2021
Merged

Conversation

echeble
Copy link
Contributor

@echeble echeble commented Aug 1, 2021

Upgrade plugin's supporting versions following the release of IDEA 2021.2

@echeble echeble marked this pull request as ready for review August 1, 2021 17:05
@raniejade
Copy link
Member

thanks for this @eacheble!

@echeble
Copy link
Contributor Author

echeble commented Aug 3, 2021

seems it's failing to pull from the release... maybe I have a typo in the version 🤔

@raniejade
Copy link
Member

You can take a look here: https://www.jetbrains.com/intellij-repository/releases/ if the version exists.

@echeble
Copy link
Contributor Author

echeble commented Aug 3, 2021

this time I actually tested that the kotlin version is reachable, so hopefully last commit will pass the pr build checks 🤞
If this one goes well then I'll mimic the changes on #978

@echeble
Copy link
Contributor Author

echeble commented Aug 4, 2021

@raniejade do you think we're ok with this one?
Can you also launch the build checks on #978? I replicated the changes I made here and this time will pass

@raniejade
Copy link
Member

This is good, thanks again @eacheble! I'll run the build for #978.

@raniejade raniejade merged commit 10dcf98 into spekframework:2.x Aug 5, 2021
@t0r0X
Copy link

t0r0X commented Aug 19, 2021

This ticket and #978 superceded by #979

@echeble
Copy link
Contributor Author

echeble commented Aug 19, 2021

This ticket and #978 superceded by #979

@t0r0X I don't think that's entirely accurate. This aims to a branch (2.x) which is different than 978 & 979 branch (both 2.0.x)

@t0r0X
Copy link

t0r0X commented Aug 19, 2021

This ticket and #978 superceded by #979

@t0r0X I don't think that's entirely accurate. This aims to a branch (2.x) which is different than 978 & 979 branch (both 2.0.x)

@eacheble You're right, I've overlooked that branch.

jurriaan added a commit to jurriaan/spek that referenced this pull request Dec 9, 2021
Upgrade plugin's supporting versions following the release of `IDEA 2021.3`

Based on spekframework#977
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants