Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change HildCog required field error to Name #6111

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

CarolineDenis
Copy link
Contributor

Fixes #6099

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

  • Go to a COG that has a child COG or create one.
  • Expand the child COG and remove the name of the child COG.
  • Collapse subview
  • Attempt to save.
  • verify that the warning message is: Name: Field is required

@CarolineDenis CarolineDenis added this to the 7.9.11 milestone Jan 17, 2025
@CarolineDenis CarolineDenis requested review from sharadsw and a team January 17, 2025 16:23
Copy link
Collaborator

@combs-a combs-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • verify that the warning message is: Name: Field is required

image

It's now using field's chosen name which is much better 👍

It could potentially specify it's an error in the childCOG, but I think this edge case (where Specify cannot highlight the actual field due to a form issue, and instead has to use a dialog) is unlikely to be encountered very often (hopefully).

@CarolineDenis CarolineDenis merged commit 4576f20 into production Jan 17, 2025
12 checks passed
@CarolineDenis CarolineDenis deleted the issue-6099b branch January 17, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Typo in child COG error message
4 participants