Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in child COG error message #6099

Closed
combs-a opened this issue Jan 16, 2025 · 5 comments · Fixed by #6111
Closed

Typo in child COG error message #6099

combs-a opened this issue Jan 16, 2025 · 5 comments · Fixed by #6111
Assignees
Labels
1 - Bug Incorrect behavior of the product
Milestone

Comments

@combs-a
Copy link
Collaborator

combs-a commented Jan 16, 2025

Describe the bug
There's a typo in the error for when you remove the name of a child COG from another COG .

To Reproduce
Steps to reproduce the behavior:

  1. Go to a COG that has a child COG or create one.
  2. Expand the child COG and remove the name of the child COG.
  3. Attempt to save.
  4. See typo.

Expected behavior
Should say "Child COG" instead of "Hild Cog".

Screenshots

Image

Please fill out the following information manually:

@combs-a combs-a added the 1 - Bug Incorrect behavior of the product label Jan 16, 2025
@combs-a combs-a added this to the 7.9.11 milestone Jan 16, 2025
@grantfitzsimmons grantfitzsimmons self-assigned this Jan 16, 2025
@grantfitzsimmons
Copy link
Member

grantfitzsimmons commented Jan 16, 2025

It's not coming from the schema from what I can tell, but I can recreate the issue.

Here's the schema:

SELECT slc.Name AS 'Database Field', sps.`Text` AS 'Field Label', splc.Name AS 'Database Table', slc.IsHidden AS 'Is Hidden?', slc.Format AS 'Field Format', slc.PickListName, slca.Name,
        slc.SpLocaleContainerItemID AS 'Container ID'
FROM splocaleitemstr sps
JOIN splocalecontaineritem slc ON sps.SpLocaleContainerItemNameID = slc.SpLocaleContainerItemID
JOIN splocalecontainer slca ON slc.SpLocaleContainerID = slca.SpLocaleContainerID
JOIN splocalecontainer splc ON slc.SpLocaleContainerID = splc.SpLocaleContainerID
JOIN discipline d ON slca.DisciplineID = d.disciplineId
WHERE splc.Name LIKE '%collectionobjectgroup%'
ORDER BY splc.Name;
Database Field Field Label Database Table Is Hidden? Field Format PickListName Name Container ID
igsn igsn collectionobjectgroup false null null collectionobjectgroup 5637
yesno3 yesno3 collectionobjectgroup false null null collectionobjectgroup 5653
modifiedByAgent modifiedByAgent collectionobjectgroup true null null collectionobjectgroup 5659
text1 text1 collectionobjectgroup false null null collectionobjectgroup 5642
integer3 integer3 collectionobjectgroup false null null collectionobjectgroup 5647
yesno2 yesno2 collectionobjectgroup false null null collectionobjectgroup 5652
description Desc collectionobjectgroup false null null collectionobjectgroup 5636
createdByAgent createdByAgent collectionobjectgroup true null null collectionobjectgroup 5658
timestampModified timestampModified collectionobjectgroup true null null collectionobjectgroup 5641
integer2 integer2 collectionobjectgroup false null null collectionobjectgroup 5646
parentCog Parent Cog collectionobjectgroup false null null collectionobjectgroup 5937
yesno1 yesno1 collectionobjectgroup false null null collectionobjectgroup 5651
name Naaaaame collectionobjectgroup false null null collectionobjectgroup 5635
parentCojos parentCojos collectionobjectgroup false null null collectionobjectgroup 5656
timestampCreated timestampCreated collectionobjectgroup true null null collectionobjectgroup 5640
cojo Cojo collectionobjectgroup false null null collectionobjectgroup 5935
integer1 integer1 collectionobjectgroup false null null collectionobjectgroup 5645
decimal3 decimal3 collectionobjectgroup false null null collectionobjectgroup 5650
version version collectionobjectgroup true null null collectionobjectgroup 5639
cogType cogType collectionobjectgroup false null COGTypes collectionobjectgroup 5655
children Children collectionobjectgroup false null null collectionobjectgroup 5932
text3 text3 collectionobjectgroup false null null collectionobjectgroup 5644
decimal2 decimal2 collectionobjectgroup false null null collectionobjectgroup 5649
guid guid collectionobjectgroup false null null collectionobjectgroup 5638
collection collection collectionobjectgroup false null null collectionobjectgroup 5654
collectionObjectGroupId collectionObjectGroupId collectionobjectgroup false null null collectionobjectgroup 5660
text2 text2 collectionobjectgroup false null null collectionobjectgroup 5643
decimal1 Decimal 1 :) collectionobjectgroup false null null collectionobjectgroup 5648
integer3 integer3 collectionobjectgroupjoin false null null collectionobjectgroupjoin 5672
childCog childCog collectionobjectgroupjoin false null null collectionobjectgroupjoin 5677
isPrimary isPrimary collectionobjectgroupjoin false null null collectionobjectgroupjoin 5661
timestampModified timestampModified collectionobjectgroupjoin true null null collectionobjectgroupjoin 5666
integer2 integer2 collectionobjectgroupjoin false null null collectionobjectgroupjoin 5671
parentCog parentCog collectionobjectgroupjoin false null null collectionobjectgroupjoin 5676
timestampCreated timestampCreated collectionobjectgroupjoin true null null collectionobjectgroupjoin 5665
integer1 group join int 1 collectionobjectgroupjoin false null null collectionobjectgroupjoin 5670
yesno3 yesno3 collectionobjectgroupjoin false null null collectionobjectgroupjoin 5675
version version collectionobjectgroupjoin true null null collectionobjectgroupjoin 5664
text3 text3 collectionobjectgroupjoin false null null collectionobjectgroupjoin 5669
yesno2 yesno2 collectionobjectgroupjoin false null null collectionobjectgroupjoin 5674
collectionObjectGroupJoinId collectionObjectGroupJoinId collectionobjectgroupjoin false null null collectionobjectgroupjoin 5679
precedence precedence collectionobjectgroupjoin false null null collectionobjectgroupjoin 5663
text2 text2 collectionobjectgroupjoin false null null collectionobjectgroupjoin 5668
yesno1 yesno1 collectionobjectgroupjoin false null null collectionobjectgroupjoin 5673
childCo childCo collectionobjectgroupjoin false null null collectionobjectgroupjoin 5678
isSubstrate isSubstrate collectionobjectgroupjoin false null null collectionobjectgroupjoin 5662
text1 text1 collectionobjectgroupjoin false null null collectionobjectgroupjoin 5667
name name collectionobjectgrouptype false null null collectionobjectgrouptype 5626
collection collection collectionobjectgrouptype false null null collectionobjectgrouptype 5631
timestampModified timestampModified collectionobjectgrouptype true null null collectionobjectgrouptype 5630
timestampCreated timestampCreated collectionobjectgrouptype true null null collectionobjectgrouptype 5629
cogTypeId cogTypeId collectionobjectgrouptype false null null collectionobjectgrouptype 5634
version version collectionobjectgrouptype true null null collectionobjectgrouptype 5628
modifiedByAgent modifiedByAgent collectionobjectgrouptype true null null collectionobjectgrouptype 5633
type type collectionobjectgrouptype false null SystemCOGTypes collectionobjectgrouptype 5627
createdByAgent createdByAgent collectionobjectgrouptype true null null collectionobjectgrouptype 5632

@grantfitzsimmons
Copy link
Member

Not database specific:

Image

@grantfitzsimmons grantfitzsimmons removed their assignment Jan 16, 2025
@CarolineDenis CarolineDenis self-assigned this Jan 17, 2025
@CarolineDenis
Copy link
Contributor

NOTES:
See mappingPreview.ts
Should actually be 'name' is required not ChildCog

@melton-jason
Copy link
Contributor

I also noticed that querying on the COG table then going to collection object group join -> parent -> name, the heading is 'Arent' instead of 'Parent'

image

From #6073 (comment)

I believe the issue discovered by @emenslin has the same underlying cause, so I am going to tentatively reopen this Issue for re-investigation.

@CarolineDenis
Copy link
Contributor

See #6165

@CarolineDenis CarolineDenis modified the milestones: 7.10.1, 7.10 Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Bug Incorrect behavior of the product
Projects
None yet
4 participants