Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AioHttp deprecation warning #856

Merged
merged 4 commits into from
Feb 4, 2019
Merged

Remove AioHttp deprecation warning #856

merged 4 commits into from
Feb 4, 2019

Conversation

Jyhess
Copy link
Contributor

@Jyhess Jyhess commented Jan 22, 2019

debug argument is deprecated for AioHttp.
Remove it to remove deprecation warnings in logs.

@dtkav dtkav self-assigned this Jan 24, 2019
dtkav
dtkav approved these changes Jan 24, 2019
View reviewed changes
Copy link
Collaborator

@dtkav dtkav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for doing this @Jyhess . Nice work.

@dtkav dtkav added the ready label Jan 24, 2019
@dtkav dtkav requested a review from jmcs January 24, 2019 08:43
@spec-first spec-first deleted a comment Jan 25, 2019
@dtkav dtkav requested a review from hjacobs February 3, 2019 10:54
@spec-first spec-first deleted a comment Feb 4, 2019
@jmcs
Copy link
Contributor

jmcs commented Feb 4, 2019

👍

@jmcs jmcs merged commit 34c7cb1 into spec-first:master Feb 4, 2019
@Jyhess Jyhess deleted the remove_aiohttp_warnings branch May 9, 2019 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtkav dtkav dtkav approved these changes

@jmcs jmcs Awaiting requested review from jmcs

@hjacobs hjacobs Awaiting requested review from hjacobs

Assignees

@dtkav dtkav

Labels
ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jyhess @jmcs @dtkav