Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Application(debug=True) in favor of DEBUG global flag #2859

Closed
asvetlov opened this issue Mar 20, 2018 · 3 comments
Closed

Deprecate Application(debug=True) in favor of DEBUG global flag #2859

asvetlov opened this issue Mar 20, 2018 · 3 comments
Labels
enhancement outdated server
Milestone
3.5

Comments

@asvetlov
Copy link
Member

Currently debug mode is cumbersome:

  1. User can enable it by Application(debug=True)
  2. Otherwise loop.get_debug() is used.

Better to deprecate it and always rely on PYTHONASYNCIODEBUG environment variable or shiny new python -X dev mode (https://docs.python.org/3.7/using/cmdline.html#id5)
@asvetlov asvetlov added this to the 3.2 milestone Mar 20, 2018
@asvetlov asvetlov mentioned this issue May 1, 2018
Merged
@asvetlov asvetlov modified the milestones: 3.2, 3.3 May 7, 2018
@asvetlov asvetlov modified the milestones: 3.3, 3.5 Oct 18, 2018
@aio-libs-bot aio-libs-bot mentioned this issue Nov 29, 2018
Closed
@discosultan
Copy link

It seems the flag is already deprecated. Can this issue be closed or are there any other plans around it?

@asvetlov
Copy link
Member Author

Thanks for raising the question.
Yes, the issue is done.
In aiohttp 4 we have to remove the argument entirely but it is another thing.

@Jyhess Jyhess mentioned this issue Jan 22, 2019
Merged
jmcs pushed a commit to spec-first/connexion that referenced this issue Feb 4, 2019
@Jyhess @jmcs
Remove AioHttp deprecation warning (#856)
34c7cb1 
[debug argument is deprecated](aio-libs/aiohttp#2859) for AioHttp.
Remove it to remove deprecation warnings in logs.
@lock
Copy link

lock bot commented Jan 15, 2020

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Jan 15, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement outdated server
Projects
None yet
Milestone
3.5
Development

No branches or pull requests
2 participants
@asvetlov @discosultan