Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When applying the custom directory structure as suggested by the "Laravel Beyond Crud" book, the event discovery fails as it uses the base path to guess the class names from the file names.
laravel-event-sourcing/src/Support/DiscoverEventHandlers.php
Lines 72 to 83 in 05d0aa0
So a Projector placed at
./src/App/Projectors/UsersProjector.php
is guessed as this classSrc\App\Projectors\UsersProjector
, which does not exist.By allowing a user to specify a custom config key one could add this config key:
And have the
src
part ignored.As it is seems to be an edge case, I didn't add a config key on the config stub.
If you prefer me to do so, please let know and I will update the PR.
More reasoning here: https://github.com/spatie/laravel-beyond-crud-demo/issues/7#issuecomment-792965120 (private repo)
EDIT I pushed more commits to allow for a more descriptive config key