-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.x] Allow to override discover events base path #36515
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigopedra
changed the title
Allow to override discover events base path
[8.x] Allow to override discover events base path
Mar 9, 2021
This was referenced Mar 10, 2021
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When customizing the app's directory structure event discovery fails as it uses
base_path()
to remove the "real path" part from a class file and tries to guess the class name from the remaining path.For example, if one is following "Laravel Beyond Crud" book, from Spatie, proposed file structure, and have an event placed at
./src/App/Events/UserCreated.php
, theDiscoverEvents
class will guess the namespace of that class asSrc\App\Events\UserCreated
, which PHP won't find as a class.This PR allows a developer to override in their local
EventServiceProvider
the base path used for event discovery by adding a protected method they can override and provide a custom base path to be used by theDiscoverEvents
class.EDIT no tests were added as the test for
DiscoverEvents
is already agnostic about the base path used.reference:
framework/tests/Integration/Foundation/DiscoverEventsTest.php
Lines 15 to 32 in 0798479