Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: And Convert Tiff File with OME-NGFF Zarr output #32

Merged
merged 3 commits into from
May 24, 2022

Conversation

thewtex
Copy link
Contributor

@thewtex thewtex commented May 5, 2022

@joshmoore tried to create a bioformats2raw transitional layout. Does this look correct? Can your package validate it?

@joshmoore
Copy link

This block:

store = zarr.storage.DirectoryStore(f'{image_name}.zarr', dimension_separator='/')
group = zarr.group(store, overwrite=True)
group.attrs['bioformats2raw.layout'] = 3
store['OME/METADATA.ome.xml'] = tiff.ome_metadata.encode('utf-8')

certainly looks correct. Is there one of these Zarrs somewhere that I can try to validate?

@thewtex
Copy link
Contributor Author

thewtex commented May 5, 2022

@joshmoore
Copy link

From Python 👍

ome_zarr info sub-I46_ses-SPIM_sample-BrocaAreaS01_stain-GAD67_chunk-00_SPIM.zarr/
/Users/jamoore/Downloads/sub-I46_ses-SPIM_sample-BrocaAreaS01_stain-GAD67_chunk-00_SPIM.zarr [zgroup]
 - metadata
   - bioformats2raw
 - data
/Users/jamoore/Downloads/sub-I46_ses-SPIM_sample-BrocaAreaS01_stain-GAD67_chunk-00_SPIM.zarr/0 [zgroup]
 - metadata
   - Multiscales
 - data
   - (242, 342, 3882)
   - (242, 342, 1941)
   - (121, 171, 485)
   - (30, 42, 60)

@joshmoore
Copy link

ZarrReader.java was less happy: ome/ZarrReader#31 (comment) but that may be because of orthogonal advances.

@thewtex thewtex mentioned this pull request May 16, 2022
@thewtex thewtex marked this pull request as ready for review May 24, 2022 01:21
@thewtex
Copy link
Contributor Author

thewtex commented May 24, 2022

@djarecka @yarikoptic @satra @LeeKamentsky @joshmoore please take a look

@thewtex thewtex merged commit e2d0af4 into spatial-image:main May 24, 2022
@thewtex thewtex deleted the tifffile branch May 24, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants