Merge pull request godotengine#97109 from pattlebass/pitch-shift-fix

AudioEffectPitchShift: Fix distortion when pitch is 1.0
spanzeri · Sep 17, 2024 · 27dacd5 · 27dacd5
2 parents ac78975 + 8ebabf6
commit 27dacd5
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/servers/audio/effects/audio_effect_pitch_shift.cpp b/servers/audio/effects/audio_effect_pitch_shift.cpp
@@ -286,6 +286,11 @@ void SMBPitchShift::smbFft(float *fftBuffer, long fftFrameSize, long sign)
 /* clang-format on */
 
 void AudioEffectPitchShiftInstance::process(const AudioFrame *p_src_frames, AudioFrame *p_dst_frames, int p_frame_count) {
+	// Avoid distortion by skipping processing if pitch_scale is 1.0.
+	if (Math::is_equal_approx(base->pitch_scale, 1.0f)) {
+		return;
+	}
+
 	float sample_rate = AudioServer::get_singleton()->get_mix_rate();
 
 	float *in_l = (float *)p_src_frames;