-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image segmentation docs #1821
Conversation
…bility.py to accept variable data_set names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these docs are amazing
Co-Authored-By: Tony Tung <[email protected]>
a few methods that are implemented or integrated with starfish to output a | ||
:py:class:`.BinaryMaskCollection`, which represents a collection of labeled objects. If you do not | ||
know which segmentation method to use, a safe bet is to start with thresholding and watershed. On | ||
the other hand, if you can afford to manually define ROI masks there is no better way to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is ROI common enough parlance that it's not necessary to define it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I will add an entry for ROI in the glossary and link to it.
|
||
The most accurate but time-consuming approach is to manually segment images using a tool such as | ||
`ROI manager <https://imagej.net/docs/guide/146-30.html#fig:The-ROI-Manager>`_ in FIJI (ImageJ). It | ||
is a straightforward process that starfish supports by allowing ROI set binaries to be imported as a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"ROI set binaries" is confusing to me. Do you mean ROI sets saved as binary files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that's what I meant... I got the language from some ROI manager documentation I can't find now but I agree it's confusing. How about "that starfish supports by importing ROI sets stored in ZIP archives".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good.
Co-Authored-By: Tony Tung <[email protected]>
Co-Authored-By: Tony Tung <[email protected]>
Co-Authored-By: Tony Tung <[email protected]>
Co-Authored-By: Tony Tung <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1821 +/- ##
=======================================
Coverage 90.04% 90.04%
=======================================
Files 254 254
Lines 9451 9451
=======================================
Hits 8510 8510
Misses 941 941 Continue to review full report at Codecov.
|
Added tutorials for watershed, manual, and ilastik segmentation in starfish. Also made minor edits to
from_fiji_roi_sets
docstring and changedIlastikPretrainedProbability
to clarify how to use in Windows and accept variable dataset names that are exported from ilastik.link to readthedocs