Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding mouse v human example to starfish.data #1741

Merged
merged 1 commit into from
Jan 22, 2020

Conversation

shanaxel42
Copy link
Collaborator

@shanaxel42 shanaxel42 commented Jan 21, 2020

@shanaxel42 shanaxel42 requested a review from neuromusic January 21, 2020 23:54
@codecov-io
Copy link

codecov-io commented Jan 22, 2020

Codecov Report

Merging #1741 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1741      +/-   ##
==========================================
- Coverage   90.13%   90.12%   -0.01%     
==========================================
  Files         248      248              
  Lines        9166     9168       +2     
==========================================
+ Hits         8262     8263       +1     
- Misses        904      905       +1
Impacted Files Coverage Δ
starfish/data.py 50% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d4bf2a...ae6563e. Read the comment docs.

@neuromusic
Copy link
Collaborator

Do we have any tests for the datasets module? Verifying the hash of a FOV or something?

@shanaxel42
Copy link
Collaborator Author

Do we have any tests for the datasets module? Verifying the hash of a FOV or something?

No - but those tests would take a long time.

@ttung
Copy link
Collaborator

ttung commented Jan 22, 2020

Do we have any tests for the datasets module? Verifying the hash of a FOV or something?

spacetx file format is somewhat resilient against data corruption. I think the goal of tests for starfish.data should be to verify that the data is available. If we can verify that the top level experiment.json is accessible, that is good enough for me. More than that requires more effort than I think is worth doing.

@neuromusic
Copy link
Collaborator

okay, that all makes sense.

Let's get this in and add some data availability tests as part of the durability epic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants