Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[easy] Remove physical_coordinate_calculator.py #1352

Merged
merged 1 commit into from
May 21, 2019

Conversation

ttung
Copy link
Collaborator

@ttung ttung commented May 15, 2019

Most of the functions are now only used by test code. Move _get_physical_coordinates_of_z_plane, the remaining "mainline" code into physical_coordinates.py

Test plan: pytest -v -n4 starfish/core/imagestack/test/

Depends on #1351

@ttung ttung requested a review from shanaxel42 May 15, 2019 08:22
@codecov-io
Copy link

codecov-io commented May 15, 2019

Codecov Report

Merging #1352 into master will decrease coverage by 1.27%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1352      +/-   ##
==========================================
- Coverage    90.4%   89.13%   -1.28%     
==========================================
  Files         216      147      -69     
  Lines        8223     5337    -2886     
==========================================
- Hits         7434     4757    -2677     
+ Misses        789      580     -209
Impacted Files Coverage Δ
starfish/core/imagestack/parser/tileset/_parser.py 83.54% <100%> (ø) ⬆️
...fish/core/imagestack/test/factories/with_coords.py 100% <100%> (ø) ⬆️
starfish/core/imagestack/physical_coordinates.py 100% <100%> (ø)
starfish/core/experiment/test/test_experiment.py
starfish/core/recipe/test/test_runnable.py
starfish/core/spacetx_format/test/test_validate.py
...table/test/test_stack_intensity_table_reshaping.py
...rfish/core/intensity_table/test/test_to_mermaid.py
starfish/core/test/factories.py
...tarfish/core/image/_filter/test/test_call_bases.py
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcff749...a9bae4a. Read the comment docs.

@ttung ttung force-pushed the tonytung-move-physical-calculation branch from 6309b57 to 6450ea5 Compare May 15, 2019 08:38
@ttung ttung force-pushed the tonytung-move-physical-calculation branch 2 times, most recently from 5e8ac04 to fac9eb2 Compare May 15, 2019 20:36
@ttung ttung force-pushed the tonytung-pass-array branch from 3816cd4 to 5ce988c Compare May 15, 2019 20:38
@ttung ttung force-pushed the tonytung-move-physical-calculation branch from fac9eb2 to 2d64da7 Compare May 15, 2019 20:38
@ttung ttung force-pushed the tonytung-pass-array branch from 5ce988c to d6bc600 Compare May 15, 2019 23:53
@ttung ttung force-pushed the tonytung-move-physical-calculation branch from 2d64da7 to 3655887 Compare May 15, 2019 23:53
@ttung ttung force-pushed the tonytung-pass-array branch from d6bc600 to fca77d8 Compare May 15, 2019 23:54
@ttung ttung force-pushed the tonytung-move-physical-calculation branch from 3655887 to 6d9ae8d Compare May 15, 2019 23:54
@ttung ttung force-pushed the tonytung-pass-array branch from fca77d8 to 7b65acd Compare May 16, 2019 18:42
@ttung ttung force-pushed the tonytung-move-physical-calculation branch from 6d9ae8d to 1b90161 Compare May 16, 2019 18:42
@ttung ttung force-pushed the tonytung-move-physical-calculation branch from 1b90161 to 9ee5579 Compare May 20, 2019 21:42
@ttung ttung changed the base branch from tonytung-pass-array to master May 21, 2019 17:15
Most of the functions are now only used by test code.  Move `_get_physical_coordinates_of_z_plane`, the remaining "mainline" code into physical_coordinates.py

Test plan: `pytest -v -n4 starfish/core/imagestack/test/`
@ttung ttung force-pushed the tonytung-move-physical-calculation branch from 9ee5579 to a9bae4a Compare May 21, 2019 17:32
@ttung ttung merged commit 8bc8aa4 into master May 21, 2019
@ttung ttung deleted the tonytung-move-physical-calculation branch May 21, 2019 18:18
ttung pushed a commit that referenced this pull request May 23, 2019
This is based on top of #1352 and #1291.  The most likely path for this to get merged is for #1352 (and its supporting PRs) to land, rebase #1291 on top of master, and merging this all in.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants