-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[easy] Remove physical_coordinate_calculator.py #1352
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttung
force-pushed
the
tonytung-move-physical-calculation
branch
from
May 15, 2019 08:38
6309b57
to
6450ea5
Compare
shanaxel42
approved these changes
May 15, 2019
ttung
force-pushed
the
tonytung-move-physical-calculation
branch
2 times, most recently
from
May 15, 2019 20:36
5e8ac04
to
fac9eb2
Compare
ttung
force-pushed
the
tonytung-pass-array
branch
from
May 15, 2019 20:38
3816cd4
to
5ce988c
Compare
ttung
force-pushed
the
tonytung-move-physical-calculation
branch
from
May 15, 2019 20:38
fac9eb2
to
2d64da7
Compare
ttung
force-pushed
the
tonytung-pass-array
branch
from
May 15, 2019 23:53
5ce988c
to
d6bc600
Compare
ttung
force-pushed
the
tonytung-move-physical-calculation
branch
from
May 15, 2019 23:53
2d64da7
to
3655887
Compare
ttung
force-pushed
the
tonytung-pass-array
branch
from
May 15, 2019 23:54
d6bc600
to
fca77d8
Compare
ttung
force-pushed
the
tonytung-move-physical-calculation
branch
from
May 15, 2019 23:54
3655887
to
6d9ae8d
Compare
ttung
force-pushed
the
tonytung-pass-array
branch
from
May 16, 2019 18:42
fca77d8
to
7b65acd
Compare
ttung
force-pushed
the
tonytung-move-physical-calculation
branch
from
May 16, 2019 18:42
6d9ae8d
to
1b90161
Compare
shanaxel42
approved these changes
May 17, 2019
ttung
force-pushed
the
tonytung-move-physical-calculation
branch
from
May 20, 2019 21:42
1b90161
to
9ee5579
Compare
Most of the functions are now only used by test code. Move `_get_physical_coordinates_of_z_plane`, the remaining "mainline" code into physical_coordinates.py Test plan: `pytest -v -n4 starfish/core/imagestack/test/`
ttung
force-pushed
the
tonytung-move-physical-calculation
branch
from
May 21, 2019 17:32
9ee5579
to
a9bae4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the functions are now only used by test code. Move
_get_physical_coordinates_of_z_plane
, the remaining "mainline" code into physical_coordinates.pyTest plan:
pytest -v -n4 starfish/core/imagestack/test/
Depends on #1351