ImageStack parsers should provide coordinates as an array #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1351 +/- ##
==========================================
+ Coverage 89.05% 89.17% +0.11%
==========================================
Files 147 147
Lines 5355 5358 +3
==========================================
+ Hits 4769 4778 +9
+ Misses 586 580 -6
Continue to review full report at Codecov.
|
ttung
force-pushed
the
tonytung-improve-physical-calculation
branch
from
832304e to
6020ead
Compare
ttung
force-pushed
the
tonytung-pass-array
branch
from
0718de2 to
2b78fb2
Compare
ttung
force-pushed
the
tonytung-improve-physical-calculation
branch
from
6020ead to
c80e9fc
Compare
ttung
force-pushed
the
tonytung-pass-array
branch
from
2b78fb2 to
3100881
Compare
ttung
force-pushed
the
tonytung-improve-physical-calculation
branch
from
c80e9fc to
661ced4
Compare
ttung
force-pushed
the
tonytung-pass-array
branch
4 times, most recently
from
d6bc600 to
fca77d8
Compare
ttung
changed the base branch from
tonytung-improve-physical-calculation
to
master
ttung
force-pushed
the
tonytung-pass-array
branch
from
fca77d8 to
7b65acd
Compare
The coordinates for zplanes need to be a sequence of coordinate values since a start/end range does not work for irregularly spaced coordinates. To make the API consistent, this PR passes _all_ coordinates to the numpy parser and between the parsers and ImageStack as sequences of coordinate values. Add a test for from_numpy(..) to verify that construction of an ImageStack from a numpy array with coordinates works correctly. Test plan: `pytest -v -n4 starfish/core/imagestack/test/`
ttung
force-pushed
the
tonytung-pass-array
branch
from
7b65acd to
198335a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The coordinates for zplanes need to be a sequence of coordinate values since a start/end range does not work for irregularly spaced coordinates. To make the API consistent, this PR passes all coordinates to the numpy parser and between the parsers and ImageStack as sequences of coordinate values.
Add a test for from_numpy(..) to verify that construction of an ImageStack from a numpy array with coordinates works correctly.
Test plan:
pytest -v -n4 starfish/core/imagestack/test/Depends on #1350