Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move build configuration into pyproject.toml #13

Merged
merged 3 commits into from
Nov 2, 2022

Conversation

zacharyburnett
Copy link
Collaborator

setuptools now supports the [project] table, which is defined by PEP621.

Additionally, setuptools now supports its own entry in pyproject.toml called [tool.setuptools] (pypa/setuptools#1688, https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html#setuptools-specific-configuration); however, it comes with the following disclaimer:

Support for declaring configurations not standardized by PEP 621 (i.e. the [tool.setuptools] table), is still in beta stage and might change in future releases.

Support for the tool.setuptools table will likely be in beta until toml is natively supported with the release of Python 3.11.

Given this, we can attempt to consolidate the build configuration into a single pyproject.toml file that can possibly be read by other build systems in the future.

@zacharyburnett zacharyburnett self-assigned this Oct 26, 2022
@zacharyburnett zacharyburnett force-pushed the pep621 branch 3 times, most recently from 3c302e1 to b7b9919 Compare October 26, 2022 13:53
@schlafly
Copy link
Collaborator

Thanks. I have no experience with this kind of packaging and will defer to you. Should we go ahead and merge this?

@zacharyburnett
Copy link
Collaborator Author

Thanks. I have no experience with this kind of packaging and will defer to you. Should we go ahead and merge this?

I'd wait until the unit tests are in so we can test it, but sure

@zacharyburnett zacharyburnett marked this pull request as ready for review November 1, 2022 18:26
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Base: 0.88% // Head: 0.88% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (6c4fd91) compared to base (c63a76b).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #13   +/-   ##
=====================================
  Coverage   0.88%   0.88%           
=====================================
  Files         12      12           
  Lines        792     791    -1     
=====================================
  Hits           7       7           
+ Misses       785     784    -1     
Flag Coverage Δ
unit 0.88% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
setup.py 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zacharyburnett zacharyburnett merged commit 0dc03ac into spacetelescope:main Nov 2, 2022
@zacharyburnett zacharyburnett deleted the pep621 branch November 2, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants