-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rcal-298: Set Up Testing Infrastructure #14
Rcal-298: Set Up Testing Infrastructure #14
Conversation
I left significant code changes I made in comments, which I can clean up before transition from draft PR to full PR. Please let me know if you guys see anything that should be changed, tests that should be excised, etc. |
This all looks good to me. I added a comment about one change I worry will break things, where I intentionally suppresed some exceptions when converting some metadata between the kinds than CRDS accepts and the kinds in the image model metadata. I'm sure there's a better way to handle the metadata passing, but I don't want to break the current hack-y functionality with this PR. You can go ahead and delete all the commented code as far as I can tell. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM
@zacharyburnett @WilliamJamieson The codecoverage report is still not working in the environment, though the commands run locally. Any ideas why that would be? |
@PaulHuwe I tested removing |
Co-authored-by: Zach Burnett <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
======================================
Coverage ? 0.88%
======================================
Files ? 12
Lines ? 792
Branches ? 0
======================================
Hits ? 7
Misses ? 785
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
🚀 |
This ticket sets up the GitHub actions for RomanISim. The actions are a straight port of the ones form RomanCAL. In addition, I modified the code to pass all the checks (sans test coverage - that will be delineated in other tickets).