Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rcal-298: Set Up Testing Infrastructure #14

Merged

Conversation

PaulHuwe
Copy link
Collaborator

This ticket sets up the GitHub actions for RomanISim. The actions are a straight port of the ones form RomanCAL. In addition, I modified the code to pass all the checks (sans test coverage - that will be delineated in other tickets).

@PaulHuwe
Copy link
Collaborator Author

I left significant code changes I made in comments, which I can clean up before transition from draft PR to full PR. Please let me know if you guys see anything that should be changed, tests that should be excised, etc.

romanisim/util.py Outdated Show resolved Hide resolved
@schlafly
Copy link
Collaborator

This all looks good to me. I added a comment about one change I worry will break things, where I intentionally suppresed some exceptions when converting some metadata between the kinds than CRDS accepts and the kinds in the image model metadata. I'm sure there's a better way to handle the metadata passing, but I don't want to break the current hack-y functionality with this PR. You can go ahead and delete all the commented code as far as I can tell.

Copy link
Collaborator

@ddavis-stsci ddavis-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
romanisim/apt.py Outdated Show resolved Hide resolved
romanisim/apt.py Show resolved Hide resolved
romanisim/wcs.py Outdated Show resolved Hide resolved
romanisim/wcs.py Outdated Show resolved Hide resolved
romanisim/wcs.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
romanisim/wcs.py Outdated Show resolved Hide resolved
romanisim/wcs.py Outdated Show resolved Hide resolved
@nden nden removed their request for review October 28, 2022 21:06
@PaulHuwe
Copy link
Collaborator Author

@zacharyburnett @WilliamJamieson The codecoverage report is still not working in the environment, though the commands run locally. Any ideas why that would be?

@zacharyburnett
Copy link
Collaborator

zacharyburnett commented Nov 1, 2022

@zacharyburnett @WilliamJamieson The codecoverage report is still not working in the environment, though the commands run locally. Any ideas why that would be?

@PaulHuwe I tested removing --pyargs and adding a term-missing report to the output, it seems to work. I made a change suggestion above. I'm not sure why it's not finding reportable data in the CI but hopefully this fixes it

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@05f83ad). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff           @@
##             main     #14   +/-   ##
======================================
  Coverage        ?   0.88%           
======================================
  Files           ?      12           
  Lines           ?     792           
  Branches        ?       0           
======================================
  Hits            ?       7           
  Misses          ?     785           
  Partials        ?       0           
Flag Coverage Δ
unit 0.88% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@PaulHuwe PaulHuwe marked this pull request as ready for review November 1, 2022 17:40
@PaulHuwe PaulHuwe merged commit c63a76b into spacetelescope:main Nov 1, 2022
@nden
Copy link
Collaborator

nden commented Nov 1, 2022

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants