-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Fix specviz2d test failure #2478
Conversation
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We definitely need to track down what changed here. At the least we should add a check on the length before to make sure that the intention of the test of 3 new marks works, and then probably inspect the 12 marks before this to make sure nothing has been added (like an all-nan green layer...).
I haven't been following specviz2d development so I have no idea what is going on. And I cannot look at this more today. We can merge this to get green CI and open follow up ticket to debug next sprint? |
The extra mark that didn't used to be there seems to be a I'll try to reproduce in the app and see what the mark itself is and if its "harmful" or safe to ignore and update the test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The marks itself seems to be harmless - its not visible by default, and even when made visible and the only mark, doesn't actually show anything. So I say we can merge this for now to get CI green in other PRs, but we might want a follow-up ticket/issue to try to track down the cause upstream and revert this (maybe with an inline-comment in the test pointing to that, since otherwise 11+3=15
is going to confuse someone in the future).
Added a comment. Is that sufficient? |
…8-on-v3.7.x Backport PR #2478 on branch v3.7.x (TST: Fix specviz2d test failure)
Description
I don't know why it increased to 15. I just want the green checkmark back.
Fixes #2476
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.