Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Fix specviz2d test failure #2478

Merged
merged 2 commits into from
Sep 22, 2023
Merged

TST: Fix specviz2d test failure #2478

merged 2 commits into from
Sep 22, 2023

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Sep 21, 2023

Description

I don't know why it increased to 15. I just want the green checkmark back.

Fixes #2476

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added testing no-changelog-entry-needed changelog bot directive 💤 backport-v3.7.x on-merge: backport to v3.7.x labels Sep 21, 2023
@pllim pllim added this to the 3.7.1 milestone Sep 21, 2023
@pllim pllim changed the title TST: Fix mosviz test failure TST: Fix specviz2d test failure Sep 21, 2023
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
...ctral_extraction/tests/test_spectral_extraction.py 100.00%

📢 Thoughts on this report? Let us know!.

@pllim pllim marked this pull request as ready for review September 22, 2023 00:16
Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We definitely need to track down what changed here. At the least we should add a check on the length before to make sure that the intention of the test of 3 new marks works, and then probably inspect the 12 marks before this to make sure nothing has been added (like an all-nan green layer...).

@pllim
Copy link
Contributor Author

pllim commented Sep 22, 2023

I haven't been following specviz2d development so I have no idea what is going on. And I cannot look at this more today. We can merge this to get green CI and open follow up ticket to debug next sprint?

@kecnry
Copy link
Member

kecnry commented Sep 22, 2023

The extra mark that didn't used to be there seems to be a GenericDensityMark and only appears with glue-jupyter 0.19 (but not 0.18). I'm guessing this was introduced by glue-viz/glue-jupyter#398 (even though we aren't using a scatter viewer in specviz2d). @astrofrog - is this expected?

I'll try to reproduce in the app and see what the mark itself is and if its "harmful" or safe to ignore and update the test.

Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The marks itself seems to be harmless - its not visible by default, and even when made visible and the only mark, doesn't actually show anything. So I say we can merge this for now to get CI green in other PRs, but we might want a follow-up ticket/issue to try to track down the cause upstream and revert this (maybe with an inline-comment in the test pointing to that, since otherwise 11+3=15 is going to confuse someone in the future).

@pllim
Copy link
Contributor Author

pllim commented Sep 22, 2023

maybe with an inline-comment in the test pointing to that

Added a comment. Is that sufficient?

@pllim pllim merged commit 5a21f79 into spacetelescope:main Sep 22, 2023
@pllim pllim deleted the fix-ci branch September 22, 2023 19:21
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Sep 22, 2023
pllim added a commit that referenced this pull request Sep 22, 2023
…8-on-v3.7.x

Backport PR #2478 on branch v3.7.x (TST: Fix specviz2d test failure)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive specviz2d testing 💤 backport-v3.7.x on-merge: backport to v3.7.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST: Specviz2d remote data test fails
2 participants