Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added implementation of lines in scatter viewer #398

Merged
merged 5 commits into from
Sep 21, 2023

Conversation

astrofrog
Copy link
Member

This adds support for showing lines in the scatter viewer.

This currently doesn't support showing variable colors along the line but I'm not sure if this is possible yet (bqplot/bqplot-gl#18)

cc @kecnry

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 74.35% and project coverage change: -0.11% ⚠️

Comparison is base (60f58c3) 86.84% compared to head (177a77b) 86.73%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #398      +/-   ##
==========================================
- Coverage   86.84%   86.73%   -0.11%     
==========================================
  Files          89       89              
  Lines        5077     5111      +34     
==========================================
+ Hits         4409     4433      +24     
- Misses        668      678      +10     
Files Changed Coverage Δ
glue_jupyter/bqplot/scatter/layer_artist.py 87.50% <65.51%> (-3.51%) ⬇️
glue_jupyter/bqplot/compatibility.py 83.33% <100.00%> (+8.33%) ⬆️
glue_jupyter/bqplot/scatter/tests/test_viewer.py 100.00% <100.00%> (ø)
glue_jupyter/common/state_widgets/layer_scatter.py 87.50% <100.00%> (+0.83%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants