node-split-poc: merge latest changes from develop #6647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Motivation We need to have syncv2 enabled for everyone for further testing of active syncv2. Current default settings differ from what was verified on mainnet so far, and need to be made more conservative to be on the safe side.
## Motivation Build and push mac-arm64 image
## Motivation The current systest workflow fails when merging a change that doesn't execute system tests, i.e. only documentation was changed. This should fix the issue.
## Motivation Ensure that the Kubernetes node pool for systest uses a specific, predefined node version rather than the latest available version for the cluster.
## Motivation Need proper defaults for mainnet. There were systest flakes with `syncv2` server mode enabled possibly due to increased resource usage.
…ge-develop # Conflicts: # api/grpcserver/config.go # go.mod # go.sum # node/node.go
kacpersaw
requested review from
dshulyak,
fasmat,
poszu,
ivan4th and
jellonek
as code owners
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## node-split-poc #6647 +/- ##
================================================
- Coverage 77.3% 77.1% -0.2%
================================================
Files 377 385 +8
Lines 51839 53387 +1548
================================================
+ Hits 40074 41208 +1134
- Misses 9402 9734 +332
- Partials 2363 2445 +82 ☔ View full report in Codecov by Sentry. |
poszu
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge latest changes from develop to node-split-poc